11 #include "clang/AST/ASTContext.h"
12 #include "clang/ASTMatchers/ASTMatchFinder.h"
13 #include "clang/Basic/LLVM.h"
14 #include "clang/Basic/LangOptions.h"
15 #include "clang/Basic/SourceLocation.h"
16 #include "clang/Lex/Lexer.h"
17 #include "llvm/ADT/ArrayRef.h"
18 #include "llvm/ADT/SmallSet.h"
19 #include "llvm/ADT/SmallVector.h"
20 #include "llvm/ADT/STLExtras.h"
21 #include "llvm/ADT/StringRef.h"
22 #include "llvm/Support/Casting.h"
23 #include "llvm/Support/Regex.h"
24 #include "llvm/Support/raw_ostream.h"
29 using namespace clang::ast_matchers;
37 enum BindArgumentKind { BK_Temporary, BK_Placeholder, BK_CallExpr, BK_Other };
41 BindArgumentKind
Kind = BK_Other;
47 static SmallVector<BindArgument, 4>
49 SmallVector<BindArgument, 4> BindArguments;
50 llvm::Regex MatchPlaceholder(
"^_([0-9]+)$");
53 for (
size_t I = 1, ArgCount = C->getNumArgs(); I < ArgCount; ++I) {
54 const Expr *E = C->getArg(I);
56 if (
const auto *M = dyn_cast<MaterializeTemporaryExpr>(E)) {
57 const auto *TE = M->GetTemporaryExpr();
58 B.Kind = isa<CallExpr>(TE) ? BK_CallExpr : BK_Temporary;
61 B.Tokens = Lexer::getSourceText(
62 CharSourceRange::getTokenRange(E->getLocStart(), E->getLocEnd()),
63 *Result.SourceManager, Result.Context->getLangOpts());
65 SmallVector<StringRef, 2> Matches;
66 if (B.Kind == BK_Other && MatchPlaceholder.match(B.Tokens, &Matches)) {
67 B.Kind = BK_Placeholder;
68 B.PlaceHolderIndex = std::stoi(Matches[1]);
70 BindArguments.push_back(B);
76 llvm::raw_ostream &Stream) {
77 auto MaxPlaceholderIt =
78 std::max_element(Args.begin(), Args.end(),
79 [](
const BindArgument &B1,
const BindArgument &B2) {
80 return B1.PlaceHolderIndex < B2.PlaceHolderIndex;
84 if (MaxPlaceholderIt == Args.end() || MaxPlaceholderIt->PlaceHolderIndex == 0)
87 size_t PlaceholderCount = MaxPlaceholderIt->PlaceHolderIndex;
89 StringRef Delimiter =
"";
90 for (
size_t I = 1; I <= PlaceholderCount; ++I) {
91 Stream << Delimiter <<
"auto && arg" << I;
98 llvm::raw_ostream &Stream) {
99 StringRef Delimiter =
"";
100 for (
const auto &B : Args) {
101 if (B.PlaceHolderIndex)
102 Stream << Delimiter <<
"arg" << B.PlaceHolderIndex;
104 Stream << Delimiter << B.Tokens;
110 llvm::SmallSet<size_t, 4> PlaceHolderIndices;
111 for (
const BindArgument &B : Args) {
112 if (B.PlaceHolderIndex) {
113 if (!PlaceHolderIndices.insert(B.PlaceHolderIndex).second)
120 void AvoidBindCheck::registerMatchers(MatchFinder *
Finder) {
121 if (!getLangOpts().CPlusPlus14)
126 callee(namedDecl(hasName(
"::std::bind"))),
127 hasArgument(0, declRefExpr(to(functionDecl().bind(
"f"))).bind(
"ref")))
132 void AvoidBindCheck::check(
const MatchFinder::MatchResult &
Result) {
133 const auto *MatchedDecl = Result.Nodes.getNodeAs<CallExpr>(
"bind");
134 auto Diag = diag(MatchedDecl->getLocStart(),
"prefer a lambda to std::bind");
142 if (llvm::any_of(Args,
143 [](
const BindArgument &B) {
return B.Kind == BK_CallExpr; }))
152 const auto *F = Result.Nodes.getNodeAs<FunctionDecl>(
"f");
158 if (F->getNumParams() != Args.size())
162 llvm::raw_string_ostream Stream(Buffer);
164 bool HasCapturedArgument = llvm::any_of(
165 Args, [](
const BindArgument &B) {
return B.Kind == BK_Other; });
166 const auto *Ref = Result.Nodes.getNodeAs<DeclRefExpr>(
"ref");
167 Stream <<
"[" << (HasCapturedArgument ?
"=" :
"") <<
"]";
169 Stream <<
" { return ";
170 Ref->printPretty(Stream,
nullptr, Result.Context->getPrintingPolicy());
175 Diag << FixItHint::CreateReplacement(MatchedDecl->getSourceRange(),
std::unique_ptr< ast_matchers::MatchFinder > Finder
static bool isPlaceHolderIndexRepeated(const ArrayRef< BindArgument > Args)
static void addFunctionCallArgs(const ArrayRef< BindArgument > Args, llvm::raw_ostream &Stream)
static void addPlaceholderArgs(const ArrayRef< BindArgument > Args, llvm::raw_ostream &Stream)
static SmallVector< BindArgument, 4 > buildBindArguments(const MatchFinder::MatchResult &Result, const CallExpr *C)