11 #include "clang/AST/ASTContext.h"
12 #include "clang/ASTMatchers/ASTMatchFinder.h"
13 #include "clang/Lex/Lexer.h"
14 #include "clang/Tooling/FixIt.h"
16 using namespace clang::ast_matchers;
20 namespace readability {
22 void MisplacedArrayIndexCheck::registerMatchers(MatchFinder *
Finder) {
23 Finder->addMatcher(arraySubscriptExpr(hasLHS(hasType(isInteger())),
24 hasRHS(hasType(isAnyPointer())))
29 void MisplacedArrayIndexCheck::check(
const MatchFinder::MatchResult &
Result) {
30 const auto *ArraySubscriptE =
31 Result.Nodes.getNodeAs<ArraySubscriptExpr>(
"expr");
33 auto Diag = diag(ArraySubscriptE->getLocStart(),
"confusing array subscript "
34 "expression, usually the "
35 "index is inside the []");
39 const Expr *RHSE = ArraySubscriptE->getRHS()->IgnoreParenImpCasts();
40 if (!isa<StringLiteral>(RHSE) && !isa<DeclRefExpr>(RHSE) &&
41 !isa<MemberExpr>(RHSE))
44 const StringRef LText = tooling::fixit::getText(
45 ArraySubscriptE->getLHS()->getSourceRange(), *Result.Context);
46 const StringRef RText = tooling::fixit::getText(
47 ArraySubscriptE->getRHS()->getSourceRange(), *Result.Context);
49 Diag << FixItHint::CreateReplacement(
50 ArraySubscriptE->getLHS()->getSourceRange(), RText);
51 Diag << FixItHint::CreateReplacement(
52 ArraySubscriptE->getRHS()->getSourceRange(), LText);
std::unique_ptr< ast_matchers::MatchFinder > Finder