11 #include "clang/AST/ASTContext.h" 12 #include "clang/ASTMatchers/ASTMatchFinder.h" 21 void SignedBitwiseCheck::registerMatchers(MatchFinder *Finder) {
22 const auto SignedIntegerOperand =
23 expr(ignoringImpCasts(hasType(isSignedInteger()))).bind(
"signed-operand");
29 const auto BitmaskType = namedDecl(anyOf(
30 hasName(
"::std::locale::category"), hasName(
"::std::ctype_base::mask"),
31 hasName(
"::std::ios_base::fmtflags"), hasName(
"::std::ios_base::iostate"),
32 hasName(
"::std::ios_base::openmode")));
33 const auto IsStdBitmask = ignoringImpCasts(declRefExpr(hasType(BitmaskType)));
38 allOf(anyOf(hasOperatorName(
"^"), hasOperatorName(
"|"),
39 hasOperatorName(
"&")),
41 unless(allOf(hasLHS(IsStdBitmask), hasRHS(IsStdBitmask))),
43 hasEitherOperand(SignedIntegerOperand),
44 hasLHS(hasType(isInteger())), hasRHS(hasType(isInteger()))))
45 .bind(
"binary-no-sign-interference"),
51 binaryOperator(allOf(anyOf(hasOperatorName(
"<<"), hasOperatorName(
">>")),
52 hasEitherOperand(SignedIntegerOperand),
53 hasLHS(hasType(isInteger())),
54 hasRHS(hasType(isInteger()))))
55 .bind(
"binary-sign-interference"),
59 Finder->addMatcher(unaryOperator(allOf(hasOperatorName(
"~"),
60 hasUnaryOperand(SignedIntegerOperand)))
61 .bind(
"unary-signed"),
65 void SignedBitwiseCheck::check(
const MatchFinder::MatchResult &Result) {
66 const ast_matchers::BoundNodes &N = Result.Nodes;
67 const auto *SignedOperand = N.getNodeAs<Expr>(
"signed-operand");
68 assert(SignedOperand &&
69 "No signed operand found in problematic bitwise operations");
74 if (
const auto *UnaryOp = N.getNodeAs<UnaryOperator>(
"unary-signed")) {
76 Location = UnaryOp->getLocStart();
78 if (
const auto *BinaryOp =
79 N.getNodeAs<BinaryOperator>(
"binary-no-sign-interference"))
80 Location = BinaryOp->getLocStart();
81 else if (
const auto *BinaryOp =
82 N.getNodeAs<BinaryOperator>(
"binary-sign-interference"))
83 Location = BinaryOp->getLocStart();
85 llvm_unreachable(
"unexpected matcher result");
89 "use of a signed integer operand with a %select{binary|unary}0 bitwise " 91 << IsUnary << SignedOperand->getSourceRange();