11 #include "../utils/Matchers.h" 12 #include "../utils/OptionsUtils.h" 13 #include "clang/AST/ASTContext.h" 14 #include "clang/ASTMatchers/ASTMatchFinder.h" 25 ast_matchers::internal::BindableMatcher<Stmt>
26 handleFrom(
const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle,
27 const ast_matchers::internal::Matcher<Expr> &Arg) {
28 return cxxConstructExpr(hasDeclaration(cxxMethodDecl(ofClass(IsAHandle))),
32 ast_matchers::internal::Matcher<Stmt> handleFromTemporaryValue(
33 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
37 const auto TemporaryTernary =
38 conditionalOperator(hasTrueExpression(cxxBindTemporaryExpr()),
39 hasFalseExpression(cxxBindTemporaryExpr()));
41 return handleFrom(IsAHandle, anyOf(cxxBindTemporaryExpr(), TemporaryTernary));
44 ast_matchers::internal::Matcher<RecordDecl> isASequence() {
45 return hasAnyName(
"::std::deque",
"::std::forward_list",
"::std::list",
49 ast_matchers::internal::Matcher<RecordDecl> isASet() {
50 return hasAnyName(
"::std::set",
"::std::multiset",
"::std::unordered_set",
51 "::std::unordered_multiset");
54 ast_matchers::internal::Matcher<RecordDecl> isAMap() {
55 return hasAnyName(
"::std::map",
"::std::multimap",
"::std::unordered_map",
56 "::std::unordered_multimap");
59 ast_matchers::internal::BindableMatcher<Stmt> makeContainerMatcher(
60 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
69 ignoringParenImpCasts(handleFromTemporaryValue(IsAHandle))),
73 callee(functionDecl(hasAnyName(
"assign",
"push_back",
"resize"))),
74 on(expr(hasType(hasUnqualifiedDesugaredType(
75 recordType(hasDeclaration(recordDecl(isASequence())))))))),
77 cxxMemberCallExpr(callee(functionDecl(hasName(
"insert"))),
78 on(expr(hasType(hasUnqualifiedDesugaredType(
79 recordType(hasDeclaration(recordDecl(
80 anyOf(isASequence(), isASet()))))))))),
82 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(isAMap()))),
83 hasOverloadedOperatorName(
"[]"))));
88 DanglingHandleCheck::DanglingHandleCheck(StringRef
Name,
93 "std::basic_string_view;std::experimental::basic_string_view"))),
94 IsAHandle(cxxRecordDecl(hasAnyName(std::vector<StringRef>(
95 HandleClasses.begin(), HandleClasses.end())))
103 void DanglingHandleCheck::registerMatchersForVariables(MatchFinder *Finder) {
104 const auto ConvertedHandle = handleFromTemporaryValue(IsAHandle);
108 varDecl(hasType(hasUnqualifiedDesugaredType(
109 recordType(hasDeclaration(cxxRecordDecl(IsAHandle))))),
111 exprWithCleanups(has(ignoringParenImpCasts(ConvertedHandle)))
118 hasType(hasUnqualifiedDesugaredType(
119 recordType(hasDeclaration(cxxRecordDecl(IsAHandle))))),
120 unless(parmVarDecl()),
121 hasInitializer(exprWithCleanups(has(ignoringParenImpCasts(handleFrom(
122 IsAHandle, ConvertedHandle))))
127 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(IsAHandle))),
128 hasOverloadedOperatorName(
"="),
129 hasArgument(1, ConvertedHandle))
134 Finder->addMatcher(makeContainerMatcher(IsAHandle).bind(
"bad_stmt"),
this);
137 void DanglingHandleCheck::registerMatchersForReturn(MatchFinder *Finder) {
145 has(ignoringImplicit(handleFrom(
147 handleFrom(IsAHandle,
148 declRefExpr(to(varDecl(
150 hasAutomaticStorageDuration(),
152 anyOf(hasType(arrayType()),
153 hasType(hasUnqualifiedDesugaredType(
154 recordType(hasDeclaration(recordDecl(
155 unless(IsAHandle)))))))))))))),
157 unless(hasAncestor(lambdaExpr())))
164 has(ignoringParenImpCasts(exprWithCleanups(has(ignoringParenImpCasts(
165 handleFrom(IsAHandle, handleFromTemporaryValue(IsAHandle))))))))
171 registerMatchersForVariables(Finder);
172 registerMatchersForReturn(Finder);
176 auto *Handle = Result.Nodes.getNodeAs<CXXRecordDecl>(
"handle");
177 diag(Result.Nodes.getNodeAs<Stmt>(
"bad_stmt")->getLocStart(),
178 "%0 outlives its value")
179 << Handle->getQualifiedNameAsString();
void store(ClangTidyOptions::OptionMap &Options, StringRef LocalName, StringRef Value) const
Stores an option with the check-local name LocalName with string value Value to Options.
void check(const ast_matchers::MatchFinder::MatchResult &Result) override
ClangTidyChecks that register ASTMatchers should do the actual work in here.
std::string serializeStringList(ArrayRef< std::string > Strings)
Serialize a sequence of names that can be parsed by parseStringList.
void storeOptions(ClangTidyOptions::OptionMap &Opts) override
Should store all options supported by this check with their current values or default values for opti...
Base class for all clang-tidy checks.
std::vector< std::string > parseStringList(StringRef Option)
Parse a semicolon separated list of strings.
std::map< std::string, std::string > OptionMap
void registerMatchers(ast_matchers::MatchFinder *Finder) override
Override this to register AST matchers with Finder.
Every ClangTidyCheck reports errors through a DiagnosticsEngine provided by this context.
DiagnosticBuilder diag(SourceLocation Loc, StringRef Description, DiagnosticIDs::Level Level=DiagnosticIDs::Warning)
Add a diagnostic with the check's name.