Bug Summary

File:tools/clang/lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp
Warning:line 58, column 7
Called C++ object pointer is null

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -triple x86_64-pc-linux-gnu -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name CheckerRegistration.cpp -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-eagerly-assume -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=cplusplus -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -mrelocation-model pic -pic-level 2 -mthread-model posix -relaxed-aliasing -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu x86-64 -dwarf-column-info -debugger-tuning=gdb -momit-leaf-frame-pointer -ffunction-sections -fdata-sections -resource-dir /usr/lib/llvm-7/lib/clang/7.0.0 -D _DEBUG -D _GNU_SOURCE -D __STDC_CONSTANT_MACROS -D __STDC_FORMAT_MACROS -D __STDC_LIMIT_MACROS -I /build/llvm-toolchain-snapshot-7~svn329677/build-llvm/tools/clang/lib/StaticAnalyzer/Frontend -I /build/llvm-toolchain-snapshot-7~svn329677/tools/clang/lib/StaticAnalyzer/Frontend -I /build/llvm-toolchain-snapshot-7~svn329677/tools/clang/include -I /build/llvm-toolchain-snapshot-7~svn329677/build-llvm/tools/clang/include -I /build/llvm-toolchain-snapshot-7~svn329677/build-llvm/include -I /build/llvm-toolchain-snapshot-7~svn329677/include -I /build/llvm-toolchain-snapshot-7~svn329677/build-llvm/tools/clang/lib/StaticAnalyzer/Frontend/../Checkers -U NDEBUG -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/c++/7.3.0 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/x86_64-linux-gnu/c++/7.3.0 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/x86_64-linux-gnu/c++/7.3.0 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/c++/7.3.0/backward -internal-isystem /usr/include/clang/7.0.0/include/ -internal-isystem /usr/local/include -internal-isystem /usr/lib/llvm-7/lib/clang/7.0.0/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O2 -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -Wno-long-long -Wno-maybe-uninitialized -Wno-comment -std=c++11 -fdeprecated-macro -fdebug-compilation-dir /build/llvm-toolchain-snapshot-7~svn329677/build-llvm/tools/clang/lib/StaticAnalyzer/Frontend -ferror-limit 19 -fmessage-length 0 -fvisibility-inlines-hidden -fobjc-runtime=gcc -fno-common -fdiagnostics-show-option -vectorize-loops -vectorize-slp -analyzer-checker optin.performance.Padding -analyzer-output=html -analyzer-config stable-report-filename=true -o /tmp/scan-build-2018-04-11-031539-24776-1 -x c++ /build/llvm-toolchain-snapshot-7~svn329677/tools/clang/lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp
1//===--- CheckerRegistration.cpp - Registration for the Analyzer Checkers -===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// Defines the registration function for the analyzer checkers.
11//
12//===----------------------------------------------------------------------===//
13
14#include "clang/StaticAnalyzer/Frontend/CheckerRegistration.h"
15#include "clang/Basic/Diagnostic.h"
16#include "clang/Frontend/FrontendDiagnostic.h"
17#include "clang/StaticAnalyzer/Checkers/ClangCheckers.h"
18#include "clang/StaticAnalyzer/Core/AnalyzerOptions.h"
19#include "clang/StaticAnalyzer/Core/CheckerManager.h"
20#include "clang/StaticAnalyzer/Core/CheckerOptInfo.h"
21#include "clang/StaticAnalyzer/Core/CheckerRegistry.h"
22#include "clang/StaticAnalyzer/Frontend/FrontendActions.h"
23#include "llvm/ADT/SmallVector.h"
24#include "llvm/Support/DynamicLibrary.h"
25#include "llvm/Support/Path.h"
26#include "llvm/Support/raw_ostream.h"
27#include <memory>
28
29using namespace clang;
30using namespace ento;
31using llvm::sys::DynamicLibrary;
32
33namespace {
34class ClangCheckerRegistry : public CheckerRegistry {
35 typedef void (*RegisterCheckersFn)(CheckerRegistry &);
36
37 static bool isCompatibleAPIVersion(const char *versionString);
38 static void warnIncompatible(DiagnosticsEngine *diags, StringRef pluginPath,
39 const char *pluginAPIVersion);
40
41public:
42 ClangCheckerRegistry(ArrayRef<std::string> plugins,
43 DiagnosticsEngine *diags = nullptr);
44};
45
46} // end anonymous namespace
47
48ClangCheckerRegistry::ClangCheckerRegistry(ArrayRef<std::string> plugins,
49 DiagnosticsEngine *diags) {
50 registerBuiltinCheckers(*this);
51
52 for (ArrayRef<std::string>::iterator i = plugins.begin(), e = plugins.end();
4
Loop condition is true. Entering loop body
53 i != e; ++i) {
3
Assuming 'i' is not equal to 'e'
54 // Get access to the plugin.
55 std::string err;
56 DynamicLibrary lib = DynamicLibrary::getPermanentLibrary(i->c_str(), &err);
57 if (!lib.isValid()) {
5
Taking true branch
58 diags->Report(diag::err_fe_unable_to_load_plugin) << *i << err;
6
Called C++ object pointer is null
59 continue;
60 }
61
62 // See if it's compatible with this build of clang.
63 const char *pluginAPIVersion =
64 (const char *) lib.getAddressOfSymbol("clang_analyzerAPIVersionString");
65 if (!isCompatibleAPIVersion(pluginAPIVersion)) {
66 warnIncompatible(diags, *i, pluginAPIVersion);
67 continue;
68 }
69
70 // Register its checkers.
71 RegisterCheckersFn registerPluginCheckers =
72 (RegisterCheckersFn) (intptr_t) lib.getAddressOfSymbol(
73 "clang_registerCheckers");
74 if (registerPluginCheckers)
75 registerPluginCheckers(*this);
76 }
77}
78
79bool ClangCheckerRegistry::isCompatibleAPIVersion(const char *versionString) {
80 // If the version string is null, it's not an analyzer plugin.
81 if (!versionString)
82 return false;
83
84 // For now, none of the static analyzer API is considered stable.
85 // Versions must match exactly.
86 return strcmp(versionString, CLANG_ANALYZER_API_VERSION_STRING"7.0.0") == 0;
87}
88
89void ClangCheckerRegistry::warnIncompatible(DiagnosticsEngine *diags,
90 StringRef pluginPath,
91 const char *pluginAPIVersion) {
92 if (!diags)
93 return;
94 if (!pluginAPIVersion)
95 return;
96
97 diags->Report(diag::warn_incompatible_analyzer_plugin_api)
98 << llvm::sys::path::filename(pluginPath);
99 diags->Report(diag::note_incompatible_analyzer_plugin_api)
100 << CLANG_ANALYZER_API_VERSION_STRING"7.0.0"
101 << pluginAPIVersion;
102}
103
104static SmallVector<CheckerOptInfo, 8>
105getCheckerOptList(const AnalyzerOptions &opts) {
106 SmallVector<CheckerOptInfo, 8> checkerOpts;
107 for (unsigned i = 0, e = opts.CheckersControlList.size(); i != e; ++i) {
108 const std::pair<std::string, bool> &opt = opts.CheckersControlList[i];
109 checkerOpts.push_back(CheckerOptInfo(opt.first, opt.second));
110 }
111 return checkerOpts;
112}
113
114std::unique_ptr<CheckerManager>
115ento::createCheckerManager(AnalyzerOptions &opts, const LangOptions &langOpts,
116 ArrayRef<std::string> plugins,
117 DiagnosticsEngine &diags) {
118 std::unique_ptr<CheckerManager> checkerMgr(
119 new CheckerManager(langOpts, opts));
120
121 SmallVector<CheckerOptInfo, 8> checkerOpts = getCheckerOptList(opts);
122
123 ClangCheckerRegistry allCheckers(plugins, &diags);
124 allCheckers.initializeManager(*checkerMgr, checkerOpts);
125 allCheckers.validateCheckerOptions(opts, diags);
126 checkerMgr->finishedCheckerRegistration();
127
128 for (unsigned i = 0, e = checkerOpts.size(); i != e; ++i) {
129 if (checkerOpts[i].isUnclaimed()) {
130 diags.Report(diag::err_unknown_analyzer_checker)
131 << checkerOpts[i].getName();
132 diags.Report(diag::note_suggest_disabling_all_checkers);
133 }
134
135 }
136
137 return checkerMgr;
138}
139
140void ento::printCheckerHelp(raw_ostream &out, ArrayRef<std::string> plugins) {
141 out << "OVERVIEW: Clang Static Analyzer Checkers List\n\n";
142 out << "USAGE: -analyzer-checker <CHECKER or PACKAGE,...>\n\n";
143
144 ClangCheckerRegistry(plugins).printHelp(out);
145}
146
147void ento::printEnabledCheckerList(raw_ostream &out,
148 ArrayRef<std::string> plugins,
149 const AnalyzerOptions &opts) {
150 out << "OVERVIEW: Clang Static Analyzer Enabled Checkers List\n\n";
151
152 SmallVector<CheckerOptInfo, 8> checkerOpts = getCheckerOptList(opts);
153 ClangCheckerRegistry(plugins).printList(out, checkerOpts);
1
Passing null pointer value via 2nd parameter 'diags'
2
Calling constructor for 'ClangCheckerRegistry'
154}