This is an archive of the discontinued LLVM Phabricator instance.

Differential D122099

[libc++][test][NFC] Remove libcpp-no-concepts.
ClosedPublic

Authored by Mordante on Mar 20 2022, 6:17 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG3b2e605e33bd: [libc++][test][NFC] Remove libcpp-no-concepts.
Summary

This is no longer needed.

Diff Detail

Event Timeline

Mordante created this revision.Mar 20 2022, 6:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2022, 6:17 AM
Mordante requested review of this revision.Mar 20 2022, 6:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2022, 6:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante added a comment.Mar 20 2022, 6:18 AM

I intend to land this if it passes the CI.

philnik accepted this revision.Mar 20 2022, 6:25 AM
This revision is now accepted and ready to land.Mar 20 2022, 6:25 AM
Mordante mentioned this in D122002: [libc++][ranges] Implement ranges::max.Mar 20 2022, 6:55 AM
Harbormaster completed remote builds in B155259: Diff 416776.Mar 20 2022, 7:37 AM
Mordante added a comment.Mar 20 2022, 7:38 AM

The CI failure seems unrelated to this patch. I'll land it and keep an eye on the next scheduled CI build.

This revision was landed with ongoing or failed builds.Mar 20 2022, 7:39 AM
Closed by commit rG3b2e605e33bd: [libc++][test][NFC] Remove libcpp-no-concepts. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG3b2e605e33bd: [libc++][test][NFC] Remove libcpp-no-concepts..

Revision Contents

PathSize
libcxx/
test/
libcxx/
iterators/
predef.iterators/
reverse.iterators/
1 line
std/
algorithms/
alg.sorting/
alg.min.max/
1 line
iterators/
predef.iterators/
reverse.iterators/
reverse.iter.cmp/
1 line
1 line

Diff 416782

libcxx/test/libcxx/iterators/predef.iterators/reverse.iterators/bad_template_argument.verify.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: libcpp-no-concepts
// <iterator> // <iterator>
// reverse_iterator // reverse_iterator
#include <iterator> #include <iterator>
#include "test_iterators.h" #include "test_iterators.h"
int main(int, char**) { int main(int, char**) {
using BadIter = std::reverse_iterator<forward_iterator<int*>>; using BadIter = std::reverse_iterator<forward_iterator<int*>>;
BadIter i; //expected-error-re@*:* {{static_assert failed{{.*}} "reverse_iterator<It> requires It to be a bidirectional iterator."}} BadIter i; //expected-error-re@*:* {{static_assert failed{{.*}} "reverse_iterator<It> requires It to be a bidirectional iterator."}}
return 0; return 0;
} }

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.min.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// <algorithm> // <algorithm>
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: libcpp-no-concepts
// UNSUPPORTED: libcpp-has-no-incomplete-ranges // UNSUPPORTED: libcpp-has-no-incomplete-ranges
// template<class T, class Proj = identity, // template<class T, class Proj = identity,
// indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less> // indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
// constexpr const T& ranges::min(const T& a, const T& b, Comp comp = {}, Proj proj = {}); // constexpr const T& ranges::min(const T& a, const T& b, Comp comp = {}, Proj proj = {});
// template<copyable T, class Proj = identity, // template<copyable T, class Proj = identity,
// indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less> // indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
// constexpr T ranges::min(initializer_list<T> r, Comp comp = {}, Proj proj = {}); // constexpr T ranges::min(initializer_list<T> r, Comp comp = {}, Proj proj = {});
▲ Show 20 Lines • Show All 239 Lines • Show Last 20 Lines

libcxx/test/std/iterators/predef.iterators/reverse.iterators/reverse.iter.cmp/sfinae.compile.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: libcpp-no-concepts
// <iterator> // <iterator>
// //
// reverse_iterator // reverse_iterator
// //
// template <class Iterator1, class Iterator2> // template <class Iterator1, class Iterator2>
// constexpr bool // constexpr in C++17 // constexpr bool // constexpr in C++17
// operator==(const reverse_iterator<Iterator1>& x, const reverse_iterator<Iterator2>& y); // operator==(const reverse_iterator<Iterator1>& x, const reverse_iterator<Iterator2>& y);
▲ Show 20 Lines • Show All 178 Lines • Show Last 20 Lines

libcxx/test/std/iterators/predef.iterators/reverse.iterators/sized_sentinel.compile.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: libcpp-no-concepts
// reverse_iterator // reverse_iterator
#include <iterator> #include <iterator>
#include "test_iterators.h" #include "test_iterators.h"
template<class T> concept HasMinus = requires (T t) { t - t; }; template<class T> concept HasMinus = requires (T t) { t - t; };
Show All 11 Lines