This is an archive of the discontinued LLVM Phabricator instance.

Differential D132454

[llvm][Cmake] Expand "all" in LLVM_ENABLE_PROJECTS before other checks
ClosedPublic

Authored by kadircet on Aug 23 2022, 2:06 AM.

Details

Reviewers
ilya-biryukov
Ericson2314
ldionne
Commits
rG0c9b32e7dd2d: [llvm][Cmake] Expand "all" in LLVM_ENABLE_PROJECTS before other checks

Diff Detail

Revision Contents

PathSize
llvm/
10 lines

Diff 454823

llvm/CMakeLists.txt

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines
# one for llvm+clang+... using the same sources. # one for llvm+clang+... using the same sources.
set(LLVM_ALL_PROJECTS "bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;libcxx;libcxxabi;libunwind;lld;lldb;mlir;openmp;polly;pstl") set(LLVM_ALL_PROJECTS "bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;libcxx;libcxxabi;libunwind;lld;lldb;mlir;openmp;polly;pstl")
# The flang project is not yet part of "all" projects (see C++ requirements) # The flang project is not yet part of "all" projects (see C++ requirements)
set(LLVM_EXTRA_PROJECTS "flang") set(LLVM_EXTRA_PROJECTS "flang")
# List of all known projects in the mono repo # List of all known projects in the mono repo
set(LLVM_KNOWN_PROJECTS "${LLVM_ALL_PROJECTS};${LLVM_EXTRA_PROJECTS}") set(LLVM_KNOWN_PROJECTS "${LLVM_ALL_PROJECTS};${LLVM_EXTRA_PROJECTS}")
set(LLVM_ENABLE_PROJECTS "" CACHE STRING set(LLVM_ENABLE_PROJECTS "" CACHE STRING
"Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".")
# Make sure expansion happens first to not handle "all" in rest of the checks.
if( LLVM_ENABLE_PROJECTS STREQUAL "all" )
set( LLVM_ENABLE_PROJECTS ${LLVM_ALL_PROJECTS})
endif()
foreach(proj ${LLVM_ENABLE_PROJECTS}) foreach(proj ${LLVM_ENABLE_PROJECTS})
if (NOT proj STREQUAL "all" AND NOT proj STREQUAL "llvm" AND NOT "${proj}" IN_LIST LLVM_KNOWN_PROJECTS) if (NOT proj STREQUAL "llvm" AND NOT "${proj}" IN_LIST LLVM_KNOWN_PROJECTS)
MESSAGE(FATAL_ERROR "${proj} isn't a known project: ${LLVM_KNOWN_PROJECTS}") MESSAGE(FATAL_ERROR "${proj} isn't a known project: ${LLVM_KNOWN_PROJECTS}")
endif() endif()
endforeach() endforeach()
foreach(proj "libcxx" "libcxxabi" "libunwind") foreach(proj "libcxx" "libcxxabi" "libunwind")
if (${proj} IN_LIST LLVM_ENABLE_PROJECTS) if (${proj} IN_LIST LLVM_ENABLE_PROJECTS)
# TODO(Ericson2314): Making non-fatal for now because of out-of-tree docs # TODO(Ericson2314): Making non-fatal for now because of out-of-tree docs
# CI jobs use this. # CI jobs use this.
message(SEND_ERROR message(SEND_ERROR
"Using LLVM_ENABLE_PROJECTS=${proj} is incorrect. Please use -DLLVM_ENABLE_RUNTIMES=${proj} or " "Using LLVM_ENABLE_PROJECTS=${proj} is incorrect. Please use -DLLVM_ENABLE_RUNTIMES=${proj} or "
"see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes.") "see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes.")
endif() endif()
endforeach() endforeach()
if( LLVM_ENABLE_PROJECTS STREQUAL "all" )
set( LLVM_ENABLE_PROJECTS ${LLVM_ALL_PROJECTS})
endif()
if ("flang" IN_LIST LLVM_ENABLE_PROJECTS) if ("flang" IN_LIST LLVM_ENABLE_PROJECTS)
if (NOT "mlir" IN_LIST LLVM_ENABLE_PROJECTS) if (NOT "mlir" IN_LIST LLVM_ENABLE_PROJECTS)
message(STATUS "Enabling MLIR as a dependency to flang") message(STATUS "Enabling MLIR as a dependency to flang")
list(APPEND LLVM_ENABLE_PROJECTS "mlir") list(APPEND LLVM_ENABLE_PROJECTS "mlir")
endif() endif()
if (NOT "clang" IN_LIST LLVM_ENABLE_PROJECTS) if (NOT "clang" IN_LIST LLVM_ENABLE_PROJECTS)
message(FATAL_ERROR "Clang is not enabled, but is required for the Flang driver") message(FATAL_ERROR "Clang is not enabled, but is required for the Flang driver")
▲ Show 20 Lines • Show All 1,191 Lines • Show Last 20 Lines