This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Use LLVM_ENABLE_RUNTIMES instead of LLVM_ENABLE_PROJECTS in the symbolizer
AbandonedPublic

Authored by ldionne on Aug 23 2022, 7:00 AM.

Download Raw Diff

Details

Reviewers

phosek
Ericson2314

Summary

This was originally part of 176db3b3ab25 (D132324) which was reverted in
342e0ebd0b74 because it caused CI instability. This change is required
for compiler-rt to stop depending on the deprecated way of building libc++.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ldionne created this revision.Aug 23 2022, 7:00 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 7:00 AM

Herald added subscribers: Enna1, dberris. · View Herald Transcript

ldionne requested review of this revision.Aug 23 2022, 7:00 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 7:00 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

Harbormaster completed remote builds in B182839: Diff 454827.Aug 23 2022, 7:22 AM

Code looks good.

I don't recall build failures emails mentioning the symbolizer, so hopefully it doesn't cause CI problems too!

This revision is now accepted and ready to land.Aug 23 2022, 7:38 AM

@vitalybuka I should have pinged you on this, I just saw 89476dbca18c20edfa02548061cdee77d4808427!

I guess this doesn't have a purpose anymore. @vitalybuka thanks for cleaning it up!

Revision Contents

Path

Size

compiler-rt/

lib/

sanitizer_common/

symbolizer/

scripts/

build_symbolizer.sh

6 lines

Diff 454827

compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

	Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Lines
	CC=$CC CFLAGS="$FLAGS" RANLIB=/bin/true ./configure --static			CC=$CC CFLAGS="$FLAGS" RANLIB=/bin/true ./configure --static
	make -j${J} libz.a			make -j${J} libz.a

	# Build and install libcxxabi and libcxx.			# Build and install libcxxabi and libcxx.
	if [[ ! -d ${LIBCXX_BUILD} ]]; then			if [[ ! -d ${LIBCXX_BUILD} ]]; then
	mkdir -p ${LIBCXX_BUILD}			mkdir -p ${LIBCXX_BUILD}
	cd ${LIBCXX_BUILD}			cd ${LIBCXX_BUILD}
	LIBCXX_FLAGS="${FLAGS} -Wno-macro-redefined"			LIBCXX_FLAGS="${FLAGS} -Wno-macro-redefined"
	PROJECTS=			RUNTIMES=
	if [[ ! -d $LLVM_SRC/projects/libcxxabi ]] ; then			if [[ ! -d $LLVM_SRC/projects/libcxxabi ]] ; then
	PROJECTS="-DLLVM_ENABLE_PROJECTS='libcxx;libcxxabi'"			RUNTIMES="-DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi'"
	fi			fi
	cmake -GNinja \			cmake -GNinja \
	${PROJECTS} \			${RUNTIMES} \
	-DCMAKE_BUILD_TYPE=Release \			-DCMAKE_BUILD_TYPE=Release \
	-DCMAKE_C_COMPILER=$CC \			-DCMAKE_C_COMPILER=$CC \
	-DCMAKE_CXX_COMPILER=$CXX \			-DCMAKE_CXX_COMPILER=$CXX \
	-DCMAKE_C_FLAGS_RELEASE="${LIBCXX_FLAGS}" \			-DCMAKE_C_FLAGS_RELEASE="${LIBCXX_FLAGS}" \
	-DCMAKE_CXX_FLAGS_RELEASE="${LIBCXX_FLAGS}" \			-DCMAKE_CXX_FLAGS_RELEASE="${LIBCXX_FLAGS}" \
	-DLIBCXXABI_ENABLE_ASSERTIONS=OFF \			-DLIBCXXABI_ENABLE_ASSERTIONS=OFF \
	-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF \			-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF \
	-DLIBCXXABI_ENABLE_SHARED=OFF \			-DLIBCXXABI_ENABLE_SHARED=OFF \
	▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines