This is an archive of the discontinued LLVM Phabricator instance.

Differential D144781

[libc++] Add FTM for views::as_rvalue
ClosedPublic

Authored by philnik on Feb 25 2023, 1:28 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG3d4b7a6fa8a4: [libc++] Add FTM for views::as_rvalue
Summary

views::as_rvalue was implemented in D137637, but we forgot to set the feature test macro.
Fixes #60986.

Diff Detail

Event Timeline

philnik created this revision.Feb 25 2023, 1:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 1:28 AM
Herald added a subscriber: arichardson. · View Herald Transcript
philnik requested review of this revision.Feb 25 2023, 1:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 1:28 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik edited the summary of this revision. (Show Details)Feb 25 2023, 1:28 AM
Harbormaster completed remote builds in B215907: Diff 500390.Feb 25 2023, 2:55 AM
Mordante added a comment.Feb 25 2023, 5:46 AM

LGTM!

Since this paper landed in libc++ 16 I would like to backport this patch to the LLVM 16 branch.

Mordante accepted this revision.Feb 25 2023, 5:46 AM
This revision is now accepted and ready to land.Feb 25 2023, 5:46 AM
This revision was landed with ongoing or failed builds.Feb 25 2023, 9:27 AM
Closed by commit rG3d4b7a6fa8a4: [libc++] Add FTM for views::as_rvalue (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG3d4b7a6fa8a4: [libc++] Add FTM for views::as_rvalue.

Revision Contents

PathSize
libcxx/
docs/
2 lines
include/
2 lines
test/
std/
language.support/
support.limits/
support.limits.general/
24 lines
24 lines
utils/
4 lines

Diff 500439

libcxx/docs/FeatureTestMacroTable.rst

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines.. table:: Current Status
``__cpp_lib_is_scoped_enum`` ``202011L`` ``__cpp_lib_is_scoped_enum`` ``202011L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_move_only_function`` *unimplemented* ``__cpp_lib_move_only_function`` *unimplemented*
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_optional`` ``202110L`` ``__cpp_lib_optional`` ``202110L``
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_out_ptr`` *unimplemented* ``__cpp_lib_out_ptr`` *unimplemented*
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_ranges_as_rvalue`` ``202207L``
------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk`` *unimplemented* ``__cpp_lib_ranges_chunk`` *unimplemented*
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk_by`` *unimplemented* ``__cpp_lib_ranges_chunk_by`` *unimplemented*
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_ranges_iota`` *unimplemented* ``__cpp_lib_ranges_iota`` *unimplemented*
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
``__cpp_lib_ranges_join_with`` *unimplemented* ``__cpp_lib_ranges_join_with`` *unimplemented*
------------------------------------------------- ----------------- ------------------------------------------------- -----------------
Show All 25 Lines

libcxx/include/version

Show First 20 Lines • Show All 133 Lines • ▼ Show 20 Lines
__cpp_lib_optional 202110L <optional> __cpp_lib_optional 202110L <optional>
201606L // C++17 201606L // C++17
__cpp_lib_out_ptr 202106L <memory> __cpp_lib_out_ptr 202106L <memory>
__cpp_lib_parallel_algorithm 201603L <algorithm> <numeric> __cpp_lib_parallel_algorithm 201603L <algorithm> <numeric>
__cpp_lib_polymorphic_allocator 201902L <memory_resource> __cpp_lib_polymorphic_allocator 201902L <memory_resource>
__cpp_lib_quoted_string_io 201304L <iomanip> __cpp_lib_quoted_string_io 201304L <iomanip>
__cpp_lib_ranges 202106L <algorithm> <functional> <iterator> __cpp_lib_ranges 202106L <algorithm> <functional> <iterator>
<memory> <ranges> <memory> <ranges>
__cpp_lib_ranges_as_rvalue 202207L <ranges>
__cpp_lib_ranges_chunk 202202L <ranges> __cpp_lib_ranges_chunk 202202L <ranges>
__cpp_lib_ranges_chunk_by 202202L <ranges> __cpp_lib_ranges_chunk_by 202202L <ranges>
__cpp_lib_ranges_iota 202202L <numeric> __cpp_lib_ranges_iota 202202L <numeric>
__cpp_lib_ranges_join_with 202202L <ranges> __cpp_lib_ranges_join_with 202202L <ranges>
__cpp_lib_ranges_slide 202202L <ranges> __cpp_lib_ranges_slide 202202L <ranges>
__cpp_lib_ranges_starts_ends_with 202106L <algorithm> __cpp_lib_ranges_starts_ends_with 202106L <algorithm>
__cpp_lib_ranges_to_container 202202L <deque> <forward_list> <list> __cpp_lib_ranges_to_container 202202L <deque> <forward_list> <list>
<map> <priority_queue> <queue> <map> <priority_queue> <queue>
▲ Show 20 Lines • Show All 246 Lines • ▼ Show 20 Lines
# define __cpp_lib_expected 202202L # define __cpp_lib_expected 202202L
# define __cpp_lib_forward_like 202207L # define __cpp_lib_forward_like 202207L
# define __cpp_lib_invoke_r 202106L # define __cpp_lib_invoke_r 202106L
# define __cpp_lib_is_scoped_enum 202011L # define __cpp_lib_is_scoped_enum 202011L
// # define __cpp_lib_move_only_function 202110L // # define __cpp_lib_move_only_function 202110L
# undef __cpp_lib_optional # undef __cpp_lib_optional
# define __cpp_lib_optional 202110L # define __cpp_lib_optional 202110L
// # define __cpp_lib_out_ptr 202106L // # define __cpp_lib_out_ptr 202106L
# define __cpp_lib_ranges_as_rvalue 202207L
// # define __cpp_lib_ranges_chunk 202202L // # define __cpp_lib_ranges_chunk 202202L
// # define __cpp_lib_ranges_chunk_by 202202L // # define __cpp_lib_ranges_chunk_by 202202L
// # define __cpp_lib_ranges_iota 202202L // # define __cpp_lib_ranges_iota 202202L
// # define __cpp_lib_ranges_join_with 202202L // # define __cpp_lib_ranges_join_with 202202L
// # define __cpp_lib_ranges_slide 202202L // # define __cpp_lib_ranges_slide 202202L
// # define __cpp_lib_ranges_starts_ends_with 202106L // # define __cpp_lib_ranges_starts_ends_with 202106L
// # define __cpp_lib_ranges_to_container 202202L // # define __cpp_lib_ranges_to_container 202202L
// # define __cpp_lib_ranges_zip 202110L // # define __cpp_lib_ranges_zip 202110L
Show All 13 Lines

libcxx/test/std/language.support/support.limits/support.limits.general/ranges.version.compile.pass.cpp

Show All 11 Lines
// clang-format off // clang-format off
// <ranges> // <ranges>
// Test the feature test macros defined by <ranges> // Test the feature test macros defined by <ranges>
/* Constant Value /* Constant Value
__cpp_lib_ranges 202106L [C++20] __cpp_lib_ranges 202106L [C++20]
__cpp_lib_ranges_as_rvalue 202207L [C++2b]
__cpp_lib_ranges_chunk 202202L [C++2b] __cpp_lib_ranges_chunk 202202L [C++2b]
__cpp_lib_ranges_chunk_by 202202L [C++2b] __cpp_lib_ranges_chunk_by 202202L [C++2b]
__cpp_lib_ranges_join_with 202202L [C++2b] __cpp_lib_ranges_join_with 202202L [C++2b]
__cpp_lib_ranges_slide 202202L [C++2b] __cpp_lib_ranges_slide 202202L [C++2b]
__cpp_lib_ranges_zip 202110L [C++2b] __cpp_lib_ranges_zip 202110L [C++2b]
*/ */
#include <ranges> #include <ranges>
#include "test_macros.h" #include "test_macros.h"
#if TEST_STD_VER < 14 #if TEST_STD_VER < 14
# ifdef __cpp_lib_ranges # ifdef __cpp_lib_ranges
# error "__cpp_lib_ranges should not be defined before c++20" # error "__cpp_lib_ranges should not be defined before c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
Show All 10 Lines
# endif # endif
#elif TEST_STD_VER == 14 #elif TEST_STD_VER == 14
# ifdef __cpp_lib_ranges # ifdef __cpp_lib_ranges
# error "__cpp_lib_ranges should not be defined before c++20" # error "__cpp_lib_ranges should not be defined before c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
Show All 10 Lines
# endif # endif
#elif TEST_STD_VER == 17 #elif TEST_STD_VER == 17
# ifdef __cpp_lib_ranges # ifdef __cpp_lib_ranges
# error "__cpp_lib_ranges should not be defined before c++20" # error "__cpp_lib_ranges should not be defined before c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
Show All 13 Lines
# ifndef __cpp_lib_ranges # ifndef __cpp_lib_ranges
# error "__cpp_lib_ranges should be defined in c++20" # error "__cpp_lib_ranges should be defined in c++20"
# endif # endif
# if __cpp_lib_ranges != 202106L # if __cpp_lib_ranges != 202106L
# error "__cpp_lib_ranges should have the value 202106L in c++20" # error "__cpp_lib_ranges should have the value 202106L in c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
Show All 13 Lines
# ifndef __cpp_lib_ranges # ifndef __cpp_lib_ranges
# error "__cpp_lib_ranges should be defined in c++2b" # error "__cpp_lib_ranges should be defined in c++2b"
# endif # endif
# if __cpp_lib_ranges != 202106L # if __cpp_lib_ranges != 202106L
# error "__cpp_lib_ranges should have the value 202106L in c++2b" # error "__cpp_lib_ranges should have the value 202106L in c++2b"
# endif # endif
# ifndef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should be defined in c++2b"
# endif
# if __cpp_lib_ranges_as_rvalue != 202207L
# error "__cpp_lib_ranges_as_rvalue should have the value 202207L in c++2b"
# endif
# if !defined(_LIBCPP_VERSION) # if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_ranges_chunk # ifndef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should be defined in c++2b" # error "__cpp_lib_ranges_chunk should be defined in c++2b"
# endif # endif
# if __cpp_lib_ranges_chunk != 202202L # if __cpp_lib_ranges_chunk != 202202L
# error "__cpp_lib_ranges_chunk should have the value 202202L in c++2b" # error "__cpp_lib_ranges_chunk should have the value 202202L in c++2b"
# endif # endif
# else // _LIBCPP_VERSION # else // _LIBCPP_VERSION
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines

libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Lines/* Constant Value
__cpp_lib_null_iterators 201304L [C++14] __cpp_lib_null_iterators 201304L [C++14]
__cpp_lib_optional 201606L [C++17] __cpp_lib_optional 201606L [C++17]
202110L [C++2b] 202110L [C++2b]
__cpp_lib_out_ptr 202106L [C++2b] __cpp_lib_out_ptr 202106L [C++2b]
__cpp_lib_parallel_algorithm 201603L [C++17] __cpp_lib_parallel_algorithm 201603L [C++17]
__cpp_lib_polymorphic_allocator 201902L [C++20] __cpp_lib_polymorphic_allocator 201902L [C++20]
__cpp_lib_quoted_string_io 201304L [C++14] __cpp_lib_quoted_string_io 201304L [C++14]
__cpp_lib_ranges 202106L [C++20] __cpp_lib_ranges 202106L [C++20]
__cpp_lib_ranges_as_rvalue 202207L [C++2b]
__cpp_lib_ranges_chunk 202202L [C++2b] __cpp_lib_ranges_chunk 202202L [C++2b]
__cpp_lib_ranges_chunk_by 202202L [C++2b] __cpp_lib_ranges_chunk_by 202202L [C++2b]
__cpp_lib_ranges_iota 202202L [C++2b] __cpp_lib_ranges_iota 202202L [C++2b]
__cpp_lib_ranges_join_with 202202L [C++2b] __cpp_lib_ranges_join_with 202202L [C++2b]
__cpp_lib_ranges_slide 202202L [C++2b] __cpp_lib_ranges_slide 202202L [C++2b]
__cpp_lib_ranges_starts_ends_with 202106L [C++2b] __cpp_lib_ranges_starts_ends_with 202106L [C++2b]
__cpp_lib_ranges_to_container 202202L [C++2b] __cpp_lib_ranges_to_container 202202L [C++2b]
__cpp_lib_ranges_zip 202110L [C++2b] __cpp_lib_ranges_zip 202110L [C++2b]
▲ Show 20 Lines • Show All 477 Lines • ▼ Show 20 Lines
# ifdef __cpp_lib_quoted_string_io # ifdef __cpp_lib_quoted_string_io
# error "__cpp_lib_quoted_string_io should not be defined before c++14" # error "__cpp_lib_quoted_string_io should not be defined before c++14"
# endif # endif
# ifdef __cpp_lib_ranges # ifdef __cpp_lib_ranges
# error "__cpp_lib_ranges should not be defined before c++20" # error "__cpp_lib_ranges should not be defined before c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
▲ Show 20 Lines • Show All 658 Lines • ▼ Show 20 Lines
# if __cpp_lib_quoted_string_io != 201304L # if __cpp_lib_quoted_string_io != 201304L
# error "__cpp_lib_quoted_string_io should have the value 201304L in c++14" # error "__cpp_lib_quoted_string_io should have the value 201304L in c++14"
# endif # endif
# ifdef __cpp_lib_ranges # ifdef __cpp_lib_ranges
# error "__cpp_lib_ranges should not be defined before c++20" # error "__cpp_lib_ranges should not be defined before c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
▲ Show 20 Lines • Show All 823 Lines • ▼ Show 20 Lines
# if __cpp_lib_quoted_string_io != 201304L # if __cpp_lib_quoted_string_io != 201304L
# error "__cpp_lib_quoted_string_io should have the value 201304L in c++17" # error "__cpp_lib_quoted_string_io should have the value 201304L in c++17"
# endif # endif
# ifdef __cpp_lib_ranges # ifdef __cpp_lib_ranges
# error "__cpp_lib_ranges should not be defined before c++20" # error "__cpp_lib_ranges should not be defined before c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
▲ Show 20 Lines • Show All 1,090 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_ranges # ifndef __cpp_lib_ranges
# error "__cpp_lib_ranges should be defined in c++20" # error "__cpp_lib_ranges should be defined in c++20"
# endif # endif
# if __cpp_lib_ranges != 202106L # if __cpp_lib_ranges != 202106L
# error "__cpp_lib_ranges should have the value 202106L in c++20" # error "__cpp_lib_ranges should have the value 202106L in c++20"
# endif # endif
# ifdef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should not be defined before c++2b"
# endif
# ifdef __cpp_lib_ranges_chunk # ifdef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should not be defined before c++2b" # error "__cpp_lib_ranges_chunk should not be defined before c++2b"
# endif # endif
# ifdef __cpp_lib_ranges_chunk_by # ifdef __cpp_lib_ranges_chunk_by
# error "__cpp_lib_ranges_chunk_by should not be defined before c++2b" # error "__cpp_lib_ranges_chunk_by should not be defined before c++2b"
# endif # endif
▲ Show 20 Lines • Show All 1,237 Lines • ▼ Show 20 Lines
# ifndef __cpp_lib_ranges # ifndef __cpp_lib_ranges
# error "__cpp_lib_ranges should be defined in c++2b" # error "__cpp_lib_ranges should be defined in c++2b"
# endif # endif
# if __cpp_lib_ranges != 202106L # if __cpp_lib_ranges != 202106L
# error "__cpp_lib_ranges should have the value 202106L in c++2b" # error "__cpp_lib_ranges should have the value 202106L in c++2b"
# endif # endif
# ifndef __cpp_lib_ranges_as_rvalue
# error "__cpp_lib_ranges_as_rvalue should be defined in c++2b"
# endif
# if __cpp_lib_ranges_as_rvalue != 202207L
# error "__cpp_lib_ranges_as_rvalue should have the value 202207L in c++2b"
# endif
# if !defined(_LIBCPP_VERSION) # if !defined(_LIBCPP_VERSION)
# ifndef __cpp_lib_ranges_chunk # ifndef __cpp_lib_ranges_chunk
# error "__cpp_lib_ranges_chunk should be defined in c++2b" # error "__cpp_lib_ranges_chunk should be defined in c++2b"
# endif # endif
# if __cpp_lib_ranges_chunk != 202202L # if __cpp_lib_ranges_chunk != 202202L
# error "__cpp_lib_ranges_chunk should have the value 202202L in c++2b" # error "__cpp_lib_ranges_chunk should have the value 202202L in c++2b"
# endif # endif
# else // _LIBCPP_VERSION # else // _LIBCPP_VERSION
▲ Show 20 Lines • Show All 465 Lines • Show Last 20 Lines

libcxx/utils/generate_feature_test_macro_components.py

Show First 20 Lines • Show All 529 Lines • ▼ Show 20 Linesfeature_test_macros = [ add_version_header(x) for x in [
"name": "__cpp_lib_quoted_string_io", "name": "__cpp_lib_quoted_string_io",
"values": { "c++14": 201304 }, "values": { "c++14": 201304 },
"headers": ["iomanip"], "headers": ["iomanip"],
}, { }, {
"name": "__cpp_lib_ranges", "name": "__cpp_lib_ranges",
"values": { "c++20": 202106 }, "values": { "c++20": 202106 },
"headers": ["algorithm", "functional", "iterator", "memory", "ranges"], "headers": ["algorithm", "functional", "iterator", "memory", "ranges"],
}, { }, {
"name": "__cpp_lib_ranges_as_rvalue",
"values": { "c++2b": 202207 },
"headers": ["ranges"],
}, {
"name": "__cpp_lib_ranges_chunk", "name": "__cpp_lib_ranges_chunk",
"values": { "c++2b": 202202 }, "values": { "c++2b": 202202 },
"headers": ["ranges"], "headers": ["ranges"],
"unimplemented": True, "unimplemented": True,
}, { }, {
"name": "__cpp_lib_ranges_chunk_by", "name": "__cpp_lib_ranges_chunk_by",
"values": { "c++2b": 202202 }, "values": { "c++2b": 202202 },
"headers": ["ranges"], "headers": ["ranges"],
▲ Show 20 Lines • Show All 675 Lines • Show Last 20 Lines