Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libcxx test case failures on darwin (10.6): tor.pass, eval.pass, sleep_for.pass #20557

Closed
cmatthew opened this issue Jul 1, 2014 · 12 comments
Closed
Assignees
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@cmatthew
Copy link

cmatthew commented Jul 1, 2014

Bugzilla Link 20183
Resolution FIXED
Resolved on May 04, 2017 22:27
Version unspecified
OS MacOS X
CC @mclow

Extended Description

The following tests have been failing on Darwin of a while now:


Failing Tests (3):
libc++ :: numerics/rand/rand.device/ctor.pass.cpp
libc++ :: numerics/rand/rand.device/eval.pass.cpp
libc++ :: thread/thread.threads/thread.thread.this/sleep_for.pass.cpp

The most recent results can be found here:

http://lab.llvm.org:8013/builders/libcxx_clang-x86_64-darwin11-RA?numbuilds=50

@cmatthew
Copy link
Author

cmatthew commented Jul 1, 2014

assigned to @mclow

@mclow
Copy link
Contributor

mclow commented Jul 1, 2014

Interesting; I'm not seeing those failures in my nightly runs.
At least the first two appear to be a 10.8/10.9 thing; they pass on 10.8, fail on 10.9.

@mclow
Copy link
Contributor

mclow commented Jul 1, 2014

Interesting; I'm not seeing those failures in my nightly runs.
At least the first two appear to be a 10.8/10.9 thing; they pass on 10.8,
fail on 10.9.

This is just wrong; please disregard.

@mclow
Copy link
Contributor

mclow commented Jul 1, 2014

Are you running with a freshly built dylib?
These tests were added to test a change to src/random.cpp; code that gets included in the dylib.

If I run the tests with the libc++.dylib that Apple ships as part of 10.9, then (at least the first two tests) will fail.

P.S. For some reason, I cannot connect to lab.llvm.org:8013

@cmatthew
Copy link
Author

cmatthew commented Jul 1, 2014

test log

@cmatthew
Copy link
Author

cmatthew commented Jul 1, 2014

build log

@cmatthew
Copy link
Author

cmatthew commented Jul 1, 2014

I have added some logs that might be useful from a failing build.

These bots are running 10.6.

@mclow
Copy link
Contributor

mclow commented Jul 1, 2014

I have added some logs that might be useful from a failing build.

These bots are running 10.6.

Ah, that's the key.

Doug Gregor wrote (back in 2011, on the cfe-developers list):

Apple only supports libc++ on Mac OS 10.7 ....

And Howard Hinnant wrote (in the same thread in 2011):

Note that Apple never supported libc++ on 10.6, and I am not testing against it.

[ The thread is was titled "libc++ on Mac OS X 10.6" and started on Oct 9, 2011 ]

Why are you running 10.6 on this bot?

@cmatthew
Copy link
Author

cmatthew commented Jul 1, 2014

This bot is very old. Even though it has not been officially supported, the bot has been green and finding occasional bugs.

If this bug is 10.6 specific, the bot could be taken off line.

@mclow
Copy link
Contributor

mclow commented Jul 1, 2014

I'm willing to try to figure out what's going on here; but if it's just a problem on 10.6, I'm going to give it a lower priority than other bugs.

@cmatthew
Copy link
Author

cmatthew commented Jul 1, 2014

That sounds great. Thanks!

@llvmbot
Copy link
Collaborator

llvmbot commented May 5, 2017

All of these bugs were fixed by David Majnemer!

sleep_for.pass.cpp test was fixed by commit r210210. Also I believe ctor.pass.cpp was fixed by commit r210060 and eval.pass.cpp was fixed by r210061.

All of these tests pass against the OS X 10.12 system library but not on 10.11.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

No branches or pull requests

3 participants