Don't we have error reporting on the LLVMContext now? Is that appropriate?

Hrm. I hadn't thought of that.

Off the top of my head I have a couple of (potentially minor) objections:

(1) RuntimeDyld doesn't need/want an LLVMContext. In most contexts where you're using it you'll already have an LLVMContext too, but not everywhere. See e.g. llvm-rtdyld. Also I'm told people are using it in isolation in the real world. (That's scary in its own right, but still - apparently a thing...).

(2) I eventually want Orc to support threaded compilation, so there would be multiple LLVMContexts in play. In that case we'd still want one global error reporting mechanism.

Have I overlooked anything obvious there? If we don't go for LLVMContext I'd certainly be happy to make sure that whatever error reporting mechanism we do have can be optionally forwarded to a given context. That will make life easy in the common case where there's just one LLVMContext.

Hrm. I hadn't thought of that.

Off the top of my head I have a couple of (potentially minor) objections:

(1) RuntimeDyld doesn't need/want an LLVMContext. In most contexts where
you're using it you'll already have an LLVMContext too, but not everywhere.
See e.g. llvm-rtdyld. Also I'm told people are using it in isolation in the
real world. (That's scary in its own right, but still - apparently a
thing...).

Note that there is some desire to move the diagnostic reporting code out of lib/IR into lib/Support so that it can be used in places where a LLVMContext is not easy to get.

We can use the new Error class (include/Support/Error.h) for this now.

I've started threading Error through the implementation of RuntimeDyld. The next step is to actually tackle the SymbolResolver/MemoryManager/ORC interface redesign.

Most of the Orc code should be errorized nowadays, right? Are there any particular pieces missing?

Are there any particular pieces missing?

I don't think so (maybe there is some missing plumbing in ORCv1, but we're deprecating that now anyway). ORCv2 was written from the ground up with llvm::Error and has pretty thorough error plumbing. I'm calling this fixed. :)