Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r285254 and r285525 into the 3.9 branch #30188

Closed
llvmbot opened this issue Oct 31, 2016 · 8 comments
Closed

Merge r285254 and r285525 into the 3.9 branch #30188

llvmbot opened this issue Oct 31, 2016 · 8 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 31, 2016

Bugzilla Link 30840
Resolution FIXED
Resolved on Nov 21, 2016 15:30
Version 3.9
OS MacOS X
Blocks #29609
Attachments backport of r285254 and r285525
Reporter LLVM Bugzilla Contributor
CC @joker-eph

Extended Description

I would like to propose merging the changes...

r285254 | mehdi_amini | 2016-10-26 19:23:08 -0400 (Wed, 26 Oct 2016) | 8 lines

Unconditionally pass -lto_library to the linker on Darwin

We're only doing it with -flto currently, however it never "hurt"
to pass it, and users that are linking without -flto can get in
trouble if one of the dependency (a static library for instance)
contains bitcode.

Differential Revision: https://reviews.llvm.org/D25932

and the subsequent bug fix...

r285525 | mehdi_amini | 2016-10-30 19:26:13 -0400 (Sun, 30 Oct 2016) | 13 lines

Fix clang installed path to handle case where clang is invoked through a symlink

This code path is used when generating the path to libLTO.dylib, which
is passed to the linker as `-lto_library'.
Without this, if clang is invoked through a symlink, libLTO is
searched in a path relative to where the symlink is instead of
where clang is actually installed.

Fix #30159 .

Patch by: Jack Howarth

Differential Revision: https://reviews.llvm.org/D26116

to 3.9 branch for the 3.8.1 release

@llvmbot
Copy link
Collaborator Author

llvmbot commented Oct 31, 2016

assigned to @tstellar

@llvmbot
Copy link
Collaborator Author

llvmbot commented Oct 31, 2016

to 3.9 branch for the 3.9.1 release

@joker-eph
Copy link
Collaborator

@​tstellar: fine with me for cherry-picking in 3.9.1!

(This is interacting with the LTO linker on Darwin, which I own for Apple).

@joker-eph
Copy link
Collaborator

(Assigned to Tom)

@tstellar
Copy link
Collaborator

tstellar commented Nov 7, 2016

Hi Jack,

Go ahead and merge this into the 3.9 branch. If you are unable to do this, assign the bug back to me.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 16, 2016

Assigning back to Tom so he can do the commits into the 3.9 branch for 3.9.1.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 21, 2016

This is the last of my proposed back ports for 3.9 branch which have yet to be committed.

@joker-eph
Copy link
Collaborator

r287579 and r287580

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
Projects
None yet
Development

No branches or pull requests

3 participants