Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder() #37298

Closed
RamNalamothu opened this issue Jun 27, 2018 · 5 comments
Closed

ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder() #37298

RamNalamothu opened this issue Jun 27, 2018 · 5 comments
Labels
bugzilla Issues migrated from bugzilla lldb

Comments

@RamNalamothu
Copy link
Contributor

Bugzilla Link 37950
Resolution FIXED
Resolved on Aug 07, 2019 09:22
Version unspecified
OS Linux
Attachments Patch
CC @JDevlieghere,@RamNalamothu

Extended Description

lldb::ByteOrder ExecutionContext::GetByteOrder() const {
if (m_target_sp && m_target_sp->GetArchitecture().IsValid())
m_target_sp->GetArchitecture().GetByteOrder();
if (m_process_sp)
m_process_sp->GetByteOrder();
return endian::InlHostByteOrder();
}

As can be seen from the above piece of code, the byte order returned is always endian::InlHostByteOrder(), which is not wrong.
@RamNalamothu
Copy link
Contributor Author

As can be seen from the above piece of code, the byte order returned is
always endian::InlHostByteOrder(), which is not wrong.

always endian::InlHostByteOrder(), which is wrong. :)

@llvmbot
Copy link
Collaborator

llvmbot commented Jun 27, 2018

can you please upload this patch on Phabricator?

Thanks.

@RamNalamothu
Copy link
Contributor Author

Created https://reviews.llvm.org/D48704

@RamNalamothu
Copy link
Contributor Author

I have never run LLDB test suite myself so far and working on getting that up for writing a test case to close the review https://reviews.llvm.org/D48704.

@JDevlieghere
Copy link
Member

Fixed in r368181

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla lldb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JDevlieghere @llvmbot @RamNalamothu