The code is like it is because of #14093 ; so read that before attempting a fix.

This worked for me to fix this. It is quite a minor change.

https://gist.githubusercontent.com/iains/3b2e074d65263cd4be456c36839823d1/raw/5fdd16b2284d0bfd5d628333b80eeb49b8cbbe43/gistfile1.txt

*** Bug llvm/llvm-bugzilla-archive#40671 has been marked as a duplicate of this bug. ***

Is the proper fix being worked on?
I’d like a heads-up so I got pull from
llvm-project repo.

The "proper fix" is for GCC to fix their PPC floating point codegen, because '(9.223372036854775807e+18 / 1.0e+9)' certainly is a constant expression.

So we either use the latest GCC version which has the fix or we apply the patch on
the GCC of preference? In my environment using GCC 7.2.0 seems to be required by the CUDA toolkit.

Here's a minimal reproducer on godbolt: https://godbolt.org/z/xFkZTR

What confuses me is that the same expression that breaks with long double works with double and `float.

Also see:
https://bugzilla.redhat.com/show_bug.cgi?id=1538817

Here's my understanding:

It's a very old deficiency in gcc's handling of a unique IBM format for long long floating point values.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26374

A patch years ago was put it to indicate this type of folding could not be done:

https://gcc.gnu.org/ml/gcc-patches/2005-01/msg01966.html

And that code is more or less still in gcc8 in fold-const.c

  /* Don't constant fold this floating point operation if the
 result may dependent upon the run-time rounding mode and
 flag_rounding_math is set, or if GCC's software emulation
 is unable to accurately represent the result.  */
  if ((flag_rounding_math
   || (MODE_COMPOSITE_P (mode) && !flag_unsafe_math_optimizations))
  && (inexact || !real_identical (&result, &value)))
return NULL_TREE;

There is some work being done to change things for PPCLE but not for PPCBE:

https://fedoraproject.org/wiki/Changes/PPC64LE_Float128_Transition

There is nobody I know of who knows more about gcc and PowerPC than Iain Sandoe, and his workaround was in the patch I referenced above.

For what it is worth I patch-out the constexpr part (https://github.com/noloader/build-llvm/blob/master/build-llvm.sh#L566):

THIS_FILE=include/thread
sed -i "s/_LIBCPP_CONSTEXPR duration _Max/const duration _Max/g" "$THIS_FILE" > "$THIS_FILE.patched"
mv "$THIS_FILE.patched" "$THIS_FILE"

I patch it out because my two choices are (1) broken compile an no compiler, or (2) lose constexpr on a function I probably won't use. The value still works, its just not constexpr.

Patching-out the constexpr is a no brainer for me because I need a working compiler.

The way I understand Iain's patch, it changes the thread to sleep from thousands of years to just hundreds of years.

:>

I'm wondering if replacing long double with double isn't the better fix here.
std::chrono::nanoseconds::max() should be representable as a double.

My understanding is that the GCC bug is only triggered when using the IBM long double ABI, and that other long double ABI's are available. Is these a GCC macro we can use to detect IBM's long double specifically?

As far as I can tell from https://github.com/llvm-mirror/libcxx/blob/master/src/condition_variable.cpp#L56 whatever superlong number we pass in here gets shortened down to "0x59682F000000E941" anyway.

So Iain's 592 years is long enough to saturate the system.

Am I correct this doesn’t happen when building LLVM
with self bootstrapped LLVM?

Am I correct this doesn’t happen when building LLVM
with self bootstrapped LLVM?

That is my understanding. Building with LLVM is fine.
Also note that this is not "building LLVM", but building libc++.

By fully bootstrapped LLVM, it means that the linker also needs to be
lld, not ld nor gold?

Am I correct this doesn’t happen when building LLVM
with self bootstrapped LLVM?

That is my understanding. Building with LLVM is fine.
Also note that this is not "building LLVM", but building libc++.

By fully bootstrapped LLVM, it means that the linker also needs to be
lld, not ld nor gold?

This is a compile-time error; it hasn't gotten to the linker yet.

A similar issue recently came up in gcc’s bug tracker https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88204 on their test suite, and the resolution was to disable the test.

After 14 years, it would not seem very likely that gcc is going to fix this any time soon.

Although it is undesirable to have one system working differently than all the others, for bootstrapping libc++ with gcc on powerpc there would not appear to be a lot of other available options than a patch something like Iain’s.

Is there something about that patch (other than the systems test, which needs to be broadened out a bit) that I am missing that makes it unusable?

Fixed in r357478.

Fixed in r357478.

I don't see the Fix is in the llvm-project repo on GitHub, should I try
the svn in the meantime?

And fixed correctly in https://llvm.org/r357540

And fixed correctly in https://llvm.org/r357540

On ppc64le, the code base which has the Fix doen's get build:

$ cmake -G Ninja -DLLVM_ENABLE_PROJECTS="libcxx;libcxxabi" -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=TRUE -DCMAKE_C_COMPILER=/gpfs/software/opt/gcc/5.4.0/bin/gcc -DCMAKE_CXX_COMPILER=/gpfs/software/opt/gcc/5.4.0/bin/g++ ../llvm

BTW, it builds fine on x86.

I must be cross-eyed.

To me the original commit looks correct, and the corrected fix now looks backwards.

When building with gcc, on powerpc, don't we want to use

_LIBCPP_CONSTEXPR duration _Max = duration(ULLONG_MAX/1000000000ULL) ;

Because if so, we have that backwards now, don't we?

This is the correct patch for ppc64el. I've tested this on a Raptor System Talos II Power9 workstation.

diff --git a/libcxx/include/thread b/libcxx/include/thread
index 8c0115f87..e439f60b9 100644
--- a/libcxx/include/thread
+++ b/libcxx/include/thread
@@ -435,7 +435,12 @@ sleep_for(const chrono::duration<_Rep, _Period>& __d)
using namespace chrono;
if (__d > duration<_Rep, _Period>::zero())
{
+#if defined(_LIBCPP_COMPILER_GCC) && (powerpc || POWERPC)

•    //  GCC's long double const folding is incomplete for IBM128 long doubles.
  

•    _LIBCPP_CONSTEXPR duration<long double> _Max = duration<long double>(ULLONG_MAX/1000000000ULL);
  

+#else
_LIBCPP_CONSTEXPR duration _Max = nanoseconds::max();
+#endif
nanoseconds __ns;
if (__d < _Max)
{

Has this been landed on Trunk yet?

And note that C++14 now that is a requirement.

I confirm that I am able to build one of the LLVM projects, libcxx and libcxxabi on PowerPC natively for the first time ever. Time for changing the doc to Supported on Linux and PowerPC combination?

Build clang-8.0.1 on linux shell script.
Test on IBM Power9 Ubuntu-18.04 for ppc64le.

Patch for building llvm-8.0.1 on ppc64el.

I've attached a shell script for building clang-8.0.1 on linux. It's been test on a Power9 ppc64le system.

Created attachment 22388 [details]
Build clang-8.0.1 on linux shell script.

Test on IBM Power9 Ubuntu-18.04 for ppc64le.

Do you have build logs carried out on POWER9?

I'll rebuild it again and attach the logs in an hour or so. What do you hope to see in the logs?

I'd like to see the nightly build logs as I am on POWER8 and do build LLVM routinely by myself, when failture occurs I'd like to cross-check against it.

201908190440 clang-8.0.1 build log on ppc64le - power9
I've attached the build log. I deleted the install messages, since I can only post attachments upto 1MB here.

I can confirm that as of now (SHA cda334b) this fix is still reversed on master. Adding a NOT for the if condition (or switching the bodies for if and else) would fix it

I can also confirm that this is an issue in current master / trunk (llvm 10)
Here is my patch which I have incorporated in an spack package.
diff --git a/libcxx/include/thread b/libcxx/include/thread
index 02da703..d1677a1 100644
--- a/projects/libcxx/include/thread
+++ b/projects/libcxx/include/thread
@@ -368,9 +368,9 @@ sleep_for(const chrono::duration<_Rep, _Period>& __d)
{
#if defined(_LIBCPP_COMPILER_GCC) && (powerpc || POWERPC)
// GCC's long double const folding is incomplete for IBM128 long doubles.

•    _LIBCPP_CONSTEXPR duration<long double> _Max = nanoseconds::max();
  

-#else
_LIBCPP_CONSTEXPR duration _Max = duration(ULLONG_MAX/1000000000ULL) ;
+#else

•    _LIBCPP_CONSTEXPR duration<long double> _Max = nanoseconds::max();
  

#endif
nanoseconds __ns;
if (__d < _Max)

We have recently encountered this bug and have found that the patch in #39044 #c38 fixes it. What stands in the way of this being pushed? Would it help if I created a phab review for it?

We have recently encountered this bug and have found that the patch in
#39044 #c38 fixes it. What stands in
the way of this being pushed? Would it help if I created a phab review for
it?

Ping.

Ping. What's the best way to move this forward?

Ping.I suppose I should just take the patch to phabricator.

Fixed: https://reviews.llvm.org/D81438

mentioned in issue llvm/llvm-bugzilla-archive#40671