Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-recurse derived for redefinable functions #40681

Closed
jdoerfert opened this issue Apr 1, 2019 · 2 comments
Closed

No-recurse derived for redefinable functions #40681

jdoerfert opened this issue Apr 1, 2019 · 2 comments
Labels
bugzilla Issues migrated from bugzilla ipo Interprocedural optimizations

Comments

@jdoerfert
Copy link
Member

Bugzilla Link 41336
Resolution FIXED
Resolved on Jun 09, 2019 23:48
Version trunk
OS Linux

Extended Description

If a function can be redefined, thus if it doesn't have an "exact" definition,
we should not derive no-recurse from the body, though, we do:

Before:

define linkonce_odr i32 @​leaf_redefinable() {
ret i32 1
}

After -functionattrs:

; Function Attrs: norecurse
define linkonce_odr i32 @​leaf_redefinable() #​6 {
ret i32 1
}

@llvmbot
Copy link
Collaborator

llvmbot commented Jun 8, 2019

if function definition is not exact LLVM should not derive any attribute based on function body right?

@llvmbot
Copy link
Collaborator

llvmbot commented Jun 10, 2019

Fixed by commit https://reviews.llvm.org/rL362918

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla ipo Interprocedural optimizations
Projects
None yet
Development

No branches or pull requests

2 participants