Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_llc_test_checks.py doesn't report when a common prefix has been lost #48533

Open
RKSimon opened this issue Feb 15, 2021 · 3 comments
Open
Labels
bugzilla Issues migrated from bugzilla llvm-tools All llvm tools that do not have corresponding tag

Comments

@RKSimon
Copy link
Collaborator

RKSimon commented Feb 15, 2021

Bugzilla Link 49189
Version trunk
OS Windows NT
CC @topperc,@gregbedwell,@MaskRay,@LebedevRI,@mtrofin

Extended Description

https://reviews.llvm.org/rGf32dc6bb42fd24517289fd1e3418994daa4fec20

; RUN: llc < %s -mtriple=x86_64-- -mattr=+avx2 | FileCheck %s --check-prefixes=AVX,AVX2
; RUN: llc < %s -mtriple=x86_64-- -mattr=+avx2,+fast-variable-shuffle | FileCheck %s --check-prefixes=AVX,AVX2

update_llc_test_checks.py didn't report that two AVX2 runs had conflicting checks for all their common prefixes, which meant we lost ALL test coverage.

@mtrofin
Copy link
Member

mtrofin commented Feb 15, 2021

FWIW, I don't believe update_llc_test_checks.py ever reported (at least, not consistently) that a given RUN line ends up having no used prefix.

@RKSimon
Copy link
Collaborator Author

RKSimon commented Feb 15, 2021

FWIW, I don't believe update_llc_test_checks.py ever reported (at least, not
consistently) that a given RUN line ends up having no used prefix.

Prior to D93078, we would warn when we found a mismatch under the last remaining common prefix:

warn('Found conflicting asm under the same prefix: %r!' % (prefix,))

@mtrofin
Copy link
Member

mtrofin commented Feb 15, 2021

Which, as D93078 details, wasn't actually working; in this case, in particular, it wasn't (try sync-ing before that patch and running update_llc_test_checks)

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla llvm-tools All llvm tools that do not have corresponding tag
Projects
None yet
Development

No branches or pull requests

2 participants