Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcoreguidlines-prefer-member-initializer is unusable in release branch #48662

Closed
llvmbot opened this issue Feb 22, 2021 · 5 comments
Closed

cppcoreguidlines-prefer-member-initializer is unusable in release branch #48662

llvmbot opened this issue Feb 22, 2021 · 5 comments
Labels
bugzilla Issues migrated from bugzilla clang-tidy

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 22, 2021

Bugzilla Link 49318
Resolution FIXED
Resolved on Feb 22, 2021 16:34
Version unspecified
OS Linux
Blocks #48246
Reporter LLVM Bugzilla Contributor
CC @AaronBallman,@tstellar

Extended Description

This check has a lot of issue. It crashes with some macros - see here #47122 and a lot of fixes it suggests result in malformed code. I pushed a fix addressing the crashing as well as providing much more robust fixes(a2e15fa).
These fixes haven't had enough real world testing to justify backporting to the release, nor is the current release version really ready to stay in. I suggest patching out the check from the 12 branch in favour of introducing it in the 13 branch.
Discussed with Aaron Ballman and he suggested this was probably a favourable approach.
@AaronBallman
Copy link
Collaborator

FWIW, I think it's slightly preferred to back the check out of 12 instead of patching it at this late stage or leaving a known low-quality new check in the release.

@tstellar
Copy link
Collaborator

Can you submit a patch to remove the check?

@llvmbot
Copy link
Collaborator Author

llvmbot commented Feb 22, 2021

It may be a pain to submit a patch to remove it on the 13 branch, Is it easier to write a patch for the current 12 branch.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Feb 22, 2021

RemovePreferMemberInitializerCheck
This should apply on the release/12.X branch cleanly and remove the check and all related docs and tests

@tstellar
Copy link
Collaborator

Merged: a750a23

@tstellar tstellar mentioned this issue Jan 27, 2021
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla clang-tidy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstellar @AaronBallman @llvmbot