Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE/COFF] Error when processing files that don't have debug entry in directories header #50587

Open
alfonsosanchezbeato opened this issue Jul 28, 2021 · 3 comments
Open

[PE/COFF] Error when processing files that don't have debug entry in directories header #50587

alfonsosanchezbeato opened this issue Jul 28, 2021 · 3 comments
Assignees
@alfonsosanchezbeato
Labels
bugzilla Issues migrated from bugzilla tools:llvm-objcopy/strip

Comments

@alfonsosanchezbeato
Copy link
Member

Bugzilla Link 51243
Version trunk
OS Linux
Attachments Input file that triggers the bug, Proposed fix
CC @alexshap,@jh7370,@rupprecht

Extended Description

I get this error when trying to add a section:

$ llvm-objcopy --add-section .sect_name=<any_file> linuxaa64.efi.stub output_f
llvm-objcopy: error: 'output_f': debug directory payload outside of mapped sections not supported

While actually linuxaa64.efi.stub does not have a debug entry in the Data Directories header.
@alfonsosanchezbeato
Copy link
Member Author

assigned to @alfonsosanchezbeato

@jh7370
Copy link
Collaborator

jh7370 commented Jul 28, 2021

Hi Alfonso, I see you've uploaded a proposed fix. It's likely this will get fixed quicker, if you go through the LLVM contribution process yourself, uploading it to Phabricator for review. See https://llvm.org/docs/Contributing.html#how-to-submit-a-patch for details of the patch review and commit process, if you're not familiar with it. You will need to make sure you add a test to the patch too.

@alfonsosanchezbeato
Copy link
Member Author

Right, created https://reviews.llvm.org/D106940 now

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfonsosanchezbeato alfonsosanchezbeato

Labels
bugzilla Issues migrated from bugzilla tools:llvm-objcopy/strip
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfonsosanchezbeato @jh7370