Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InstCombine] Failure to drop sext before bitcast-icmp #50657

Closed
LebedevRI opened this issue Aug 3, 2021 · 2 comments
Closed

[InstCombine] Failure to drop sext before bitcast-icmp #50657

LebedevRI opened this issue Aug 3, 2021 · 2 comments
Labels
bugzilla Issues migrated from bugzilla

Comments

@LebedevRI
Copy link
Member

Bugzilla Link 51315
Resolution FIXED
Resolved on Aug 07, 2021 05:24
Version trunk
OS Linux
CC @RKSimon,@rotateright
Fixed by commit(s) 0369714

Extended Description

https://godbolt.org/z/Mf8vMfs5r
@rotateright
Copy link
Contributor

The improvement is clear in IR, and I don't see any real perf diff on the motivating x86 codegen from bug 51259, so we might as well go with the shorter IR:
https://reviews.llvm.org/rG0369714b3168

If there's some enhancement/generalization that would make that better, let me know. Otherwise, we can resolve this.

@LebedevRI
Copy link
Member Author

If there's some enhancement/generalization that would make that better, let
me know. Otherwise, we can resolve this.

I think we can resolve this, yes.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LebedevRI @rotateright