Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsmParser: Support MOVEM's move mask syntax #50922

Closed
mshockwave opened this issue Aug 23, 2021 · 5 comments
Closed

AsmParser: Support MOVEM's move mask syntax #50922

mshockwave opened this issue Aug 23, 2021 · 5 comments
Assignees
@ricky26
Labels
backend:m68k bugzilla Issues migrated from bugzilla

Comments

@mshockwave
Copy link
Member

Bugzilla Link 51580
Resolution FIXED
Resolved on Aug 24, 2021 03:22
Version trunk
OS All
CC @glaubitz,@mshockwave,@ricky26
Fixed by commit(s) 47f52f9

Extended Description

MOVEM is currently using special syntax like:

movem.l (%a1), %d0-%d1
               ^^^^^^^

or

movem.l (%a1), %d0,%d2
               ^^^^^^^

To express a set of registers. We need to support it in asm parser.
@mshockwave
Copy link
Member Author

assigned to @ricky26

@mshockwave
Copy link
Member Author

CC @​Ricky Taylor you might be interested.

@ricky26
Copy link
Member

ricky26 commented Aug 23, 2021

@​Min-Yih Hsu, is the example you posted correct? The comma would be ambiguous. The examples I see online use things like movem.l %a0-%a1/%d0, (%sp)+, or movem.l (%a1), %d0/%d2 in your example.

@mshockwave
Copy link
Member Author

@​Min-Yih Hsu, is the example you posted correct? The comma would be
ambiguous. The examples I see online use things like movem.l %a0-%a1/%d0, (%sp)+, or movem.l (%a1), %d0/%d2 in your example.

Hmmm...it seems like our current AsmPrinter is using comma as separator:

llvm-project/llvm/test/CodeGen/M68k/CollapseMOVEM.mir

Line 69 in ce4545d

# CHECK: movem.l %d0-%d2,%d7,%a1-%a3,%a5, (0,%sp)

But I agree with you that '/' is the correct separator here. So we need to change AsmPrinter as well.

@ricky26
Copy link
Member

ricky26 commented Aug 24, 2021

Fixed in 47f52f9

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricky26 ricky26

Labels
backend:m68k bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricky26 @mshockwave