(962a247 doesn't mention a phab review, else I would've commented there.)

Hi Nico,

Thanks for the heads up. I'll look into this today.

-- Lang.

This should be fixed by 2815ed5.

The failure is probabilistic, so I'll leave this bug open for 24 hours and then review the bot to make sure we haven't seen any more failures.

Looks like I was still missing some calls to ExecutionSession::endSession. I have added these in 19b4e3c.

Also missing calls to ExecutorProcessControl::disconnect in some unit tests. This has been fixed in adf55ac.

The test is still failing: http://45.33.8.238/macm1/19832/step_7.txt

Consistently, too: http://45.33.8.238/macm1/summary.html

It's been broken all day. Maybe it's time to revert for now?

Oops -- Disregard previous updates, they were for a related but distinct bot failure. :P

I'm looking in to this one now. If getting the bot green tonight is a priority then the test should be disabled, rather than any patches reverted -- there have been quite a few landed since yesterday, and this is likely to be a relatively quick fix.

This was a long-standing bug in JITLink MachO/arm64 that was exposed by the memory manager refactor: negative immediates on LDRLiteral19 relocations weren't being masked, leading to them overwriting opcode bits. The issue had never come up before because LDRLiteral19s were all created inside JITLink itself, and pointed at segments that were (under the old memory manager) always laid out after segments containing the LDRLiteral19 relocation, so we had never encountered a negative immediate before.

This should (finally) be fixed in 447d301 -- I'll check back in on the M1 bot shortly. Apologies again for the earlier noise with the unrelated fixes.

Looks like the the builder is passing again as of http://45.33.8.238/macm1/19846/summary.html.

Fantastic. Thanks, Lang!