-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing overrides on MultiplexASTDeserializationListener
#54521
Comments
And I did a little dig in, found out that in 2015 a similar case had taken place 5578e44. Makes one wonder. |
MultiplexASTDeserializationListener
@graydon You might check this out. |
No I have not. |
Revision URL: https://reviews.llvm.org/D123452 @lingol Sorry for the delay. Could I get your help to review and verify the patch? Thanks. |
@llvm/issue-subscribers-clang-frontend |
I'm not familiar with the LLVM dev flow. Is it OK for a total stranger to review and verify a patch? |
The LLVM committer may review the patch formally in the near future. But it is good for you to verify whether the patch can solve your issue actually, especially the situation you mentioned about Swift. If you don't want to do that, you can wait for the patch to be integrated and the new llvm version to be released. |
Thanks a lot. It's the same as my local modification. So Yes, it does fix my problem. |
Hi, I notice a missing override for ASTDeserializationListener::ModuleImportRead() on wrapper MultiplexASTDeserializationListener.
When someone has registered one or more
PluginASTAction
plugins, this bug will cause the bridging header's imported module not handled correctly for Swift.The text was updated successfully, but these errors were encountered: