Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-namespace-comment produces wrong namespace comment #56804

Closed
philnik777 opened this issue Jul 29, 2022 · 3 comments
Closed

llvm-namespace-comment produces wrong namespace comment #56804

philnik777 opened this issue Jul 29, 2022 · 3 comments
Assignees
Labels
clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature

Comments

@philnik777
Copy link
Contributor

clang-tidy currently produces // namespace ranges::__cpo for namespace ranges::inline __cpo while clang-format produces the (IMO) correct // namespace ranges::inline __cpo

@llvmbot
Copy link
Member

llvmbot commented Jul 29, 2022

@llvm/issue-subscribers-clang-tidy

@njames93
Copy link
Member

Both are technically a correct name, I think the tidy check should be updated to support writing out the inline keyword.

@njames93 njames93 self-assigned this Jul 29, 2022
@PiotrZSL PiotrZSL assigned PiotrZSL and unassigned njames93 Aug 5, 2023
@PiotrZSL PiotrZSL added enhancement Improving things as opposed to bug fixing, e.g. new or missing feature awaiting-review Has pending Phabricator review labels Aug 5, 2023
@PiotrZSL
Copy link
Member

PiotrZSL commented Aug 5, 2023

@PiotrZSL PiotrZSL removed the awaiting-review Has pending Phabricator review label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature
Projects
None yet
Development

No branches or pull requests

4 participants