LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 1136 - Rename Function::isExternal() -> isDeclaration()
Summary: Rename Function::isExternal() -> isDeclaration()
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Core LLVM classes (show other bugs)
Version: trunk
Hardware: All All
: P enhancement
Assignee: Unassigned LLVM Bugs
URL:
Keywords: code-cleanup
Depends on:
Blocks:
 
Reported: 2007-01-27 14:58 PST by Reid Spencer
Modified: 2010-02-22 12:48 PST (History)
1 user (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Reid Spencer 2007-01-27 14:58:12 PST 
For people learning LLVM, the isExternal() method on Function can be confusing.
It gets confused with isExternalLinkage(). To make things more clear in the
code, I suggest we rename this to isDeclaration() or isPrototype(). This keeps
it clear from using the word External which can cause the confusion.  There's no
functional change implied by this, just a name change.
Comment 1 Chris Lattner 2007-01-27 16:23:46 PST 
sounds like a good idea to me!
Comment 2 Reid Spencer 2007-01-30 14:12:21 PST 
Fixed.