LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 11895 - SimplifyLibCalls should be merged into instcombine
Summary: SimplifyLibCalls should be merged into instcombine
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Scalar Optimizations (show other bugs)
Version: trunk
Hardware: PC All
: P enhancement
Assignee: Meador Inge
URL:
Keywords: code-cleanup
Depends on:
Blocks:
 
Reported: 2012-01-31 05:26 PST by Chris Lattner
Modified: 2013-06-20 22:13 PDT (History)
9 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lattner 2012-01-31 05:26:42 PST 
Simplify libcalls was previously split out of instcombine so that it could be turned off with -fno-builtin.  Now that we have TargetLibraryInfo around, we don't need to do this.  Merging it into Instcombine's visitCall optimization logic would eliminate some phase ordering problems that it can have, and is a generally good cleanup anyway.
Comment 1 Meador Inge 2012-02-01 21:44:03 PST 
I would like to pick up this one if nobody is already working on it.
Comment 2 Chris Lattner 2012-02-01 23:47:58 PST 
Nice, please propose a plan on llvmdev, incremental is good :)
Comment 3 Meador Inge 2012-02-03 23:04:39 PST 
Cool.  I am working on a proposal now.
Comment 4 Meador Inge 2012-08-01 23:52:41 PDT 
Proposal here: http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-August/052283.html.
Comment 5 Meador Inge 2012-08-01 23:54:15 PDT 
Assigning to myself to refine the proposal and implement it.
Comment 6 Meador Inge 2012-10-11 08:22:39 PDT 
First patch series to implement this posted here: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20121008/152677.html.
After this initial patch gets reviewed, I can start doing the migration of the individual optimizations from SimplifyLibCalls to InstCombine fairly quickly.
Comment 7 Meador Inge 2013-06-20 22:13:30 PDT 
This is resolved now.  The simplify-libcalls pass has been fully migrated to the instcombine and function-attrs passes.