LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 1289 - Drop "implementation" keyword in AsmParser
Summary: Drop "implementation" keyword in AsmParser
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: LLVM assembly language parser (show other bugs)
Version: trunk
Hardware: All All
: P normal
Assignee: Reid Spencer
URL:
Keywords: code-cleanup
Depends on:
Blocks:
 
Reported: 2007-03-29 14:01 PDT by Reid Spencer
Modified: 2010-03-06 14:00 PST (History)
1 user (show)

See Also:
Fixed By Commit(s):


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Reid Spencer 2007-03-29 14:01:43 PDT
Before 2.0 ships, we need to drop support for parsing the implementation keyword
in AsmParser. The AsmWriter no longer generates it. It isn't needed. We also
don't want "checkpoint". Instead we do want the AsmParser to check for
incomplete types and values upon EOF. So, just move the checks done by
"implementation" into the code at the end of the parse. When this is done, the
test case:
  test/Assembler/2003-12-30-TypeMapInvalidMemory.llx
will need to be updated to drop use of "implementation".
Comment 1 Reid Spencer 2007-03-29 20:38:37 PDT
Support for checking unresolved types and undefined values at the end of the
parse was added with this patch:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070326/046479.html
Comment 2 Reid Spencer 2007-03-29 20:39:05 PDT
All that remains to do is drop the implementation keyword. When do we do this?
Comment 3 Reid Spencer 2007-04-07 15:56:54 PDT
Can we drop this now? Its been over a week since we announced it going away.
Comment 4 Reid Spencer 2007-04-08 21:01:03 PDT
Its been ten days since we notified people that "implementation" was going away.
Now its gone:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070402/047046.html