Hi, clang-format now formats the following code differently: This: static cl::opt<bool> ValueDependences("polly-value-dependences", cl::desc("Use value instead of memory based dependences"), cl::Hidden, cl::init(true), cl::cat(PollyCategory)); became: static cl::opt<bool> ValueDependences("polly-value-dependences", cl::desc("Use value instead of memory based dependences"), cl::Hidden, cl::init(true), cl::cat(PollyCategory)); I can see the reasoning behind this, but a quick grep 'grep -R cl::opt -A 2 lib/' does not show a single use of this in LLVM whereas the first one is very common. I believe this change should be disabled in the LLVM style
From my current change, clang-format is doing this too: - virtual void AddLinkRuntimeLibArgs(const ArgList &Args, - ArgStringList &CmdArgs) const = 0; - + virtual void + AddLinkRuntimeLibArgs(const llvm::opt::ArgList &Args, + llvm::opt::ArgStringList &CmdArgs) const = 0; +
I just hit this bug. We try to format: static llvm::error_code createUniqueEntity(const llvm::Twine &Model, int &ResultFD, llvm::SmallVectorImpl<char> &ResultPath, bool MakeAbsolute, unsigned Mode, FSEntity Type); as static llvm::error_code createUniqueEntity(const llvm::Twine &Model, int &ResultFD, llvm::SmallVectorImpl<char> &ResultPath, bool MakeAbsolute, unsigned Mode, FSEntity Type);
In fact, this bug was fixed by Manuel a week ago: commit 65972bc4e59c64ade6a5f2efffc0764144e809f5 Author: Manuel Klimek <klimek@google.com> Date: Fri Jun 21 17:25:42 2013 +0000 Add an option to not indent declarations when breaking after the type. Make that option the default for LLVM style. I get the right behavior with the latest version of clang. Rafael, if this does not work for you after updating clang, please reopen the bug.