LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 22431 - Using -fsanitize-blacklist=file.txt disables the default ASan blacklist
Summary: Using -fsanitize-blacklist=file.txt disables the default ASan blacklist
Status: RESOLVED FIXED
Alias: None
Product: clang
Classification: Unclassified
Component: Driver (show other bugs)
Version: trunk
Hardware: PC Windows NT
: P normal
Assignee: Alexey Samsonov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-02 06:55 PST by Timur Iskhodzhanov
Modified: 2015-02-09 06:48 PST (History)
5 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timur Iskhodzhanov 2015-02-02 06:55:35 PST 
This change fails at r227799:
diff --git test/asan/TestCases/Windows/iostream_sbo.cc test/asan/TestCases/Windows/iostream_sbo.cc
index 96a8b80..ffcd530 100644
--- test/asan/TestCases/Windows/iostream_sbo.cc
+++ test/asan/TestCases/Windows/iostream_sbo.cc
@@ -1,5 +1,10 @@
+// First, check this works with the default blacklist:
 // RUN: %clang_cl_asan -O0 %s -Fe%t
 // RUN: echo "42" | %run %t 2>&1 | FileCheck %s
+//
+// Then, make sure it still works when a user uses his own blacklist file:
+// RUN: %clang_cl_asan -O0 %s -fsanitize-blacklist=%p/../Helpers/initialization-blacklist.txt -Fe%t2
+// RUN: echo "42" | %run %t2 2>&1 | FileCheck %s

 #include <iostream>

Please note the default blacklist for windows is not empty due to http://goo.gl/L4qqUG

I'd argue that ASan should merge the user-specified blacklist with the default one rather than just replace.
Comment 1 Timur Iskhodzhanov 2015-02-02 06:56:17 PST 
Alexey,
Can you please take a look?
Comment 2 Timur Iskhodzhanov 2015-02-02 07:52:12 PST 
Just for the record, once this is fixed we should update Clang/Win revision used in Chromium and revert https://crrev.com/7949a66919a6d288451e3a818a843ea39025bd74
Comment 3 Reid Kleckner 2015-02-02 12:10:05 PST 
Be careful when rolling, as seh changes are causing instability.
Comment 4 Timur Iskhodzhanov 2015-02-02 13:17:02 PST 
Sure, I'll make sure to check the FYI bot first.
Comment 5 Alexey Samsonov 2015-02-04 11:49:49 PST 
Should be fixed by r228156.
Comment 6 Timur Iskhodzhanov 2015-02-09 06:48:36 PST 
r228573 adds an extra ASan/Win test case as in comment #0