LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 25771 - No email with 'LGTM' sent when a revision is just marked as marked as "accepted"
Summary: No email with 'LGTM' sent when a revision is just marked as marked as "accepted"
Status: NEW
Alias: None
Product: Website
Classification: Unclassified
Component: Phabricator (show other bugs)
Version: unspecified
Hardware: PC All
: P normal
Assignee: Unassigned LLVM Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-08 08:05 PST by Chandler Carruth
Modified: 2015-12-08 08:13 PST (History)
2 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chandler Carruth 2015-12-08 08:05:02 PST 
This causes folks to sometimes mark a revision accepted without adding an explicit comment, and as a consequence no email gets sent to the mailing list. This is important because folks watching the mailing list may not realize that there was an explicit LGTM given in the review.
Comment 1 Manuel Klimek 2015-12-08 08:10:54 PST 
I thought that had been fixed? It doesn't say LGTM, but it says "accepted and is ready to land" iirc?
Comment 2 Chandler Carruth 2015-12-08 08:13:27 PST 
(In reply to comment #1)
> I thought that had been fixed? It doesn't say LGTM, but it says "accepted
> and is ready to land" iirc?

It sends a private email to people not including the subscribers saying that. =/