LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 26919 - Regression(263110:263111): TestCases/Float/cast-overflow.cpp started failing on the Windows bot
Summary: Regression(263110:263111): TestCases/Float/cast-overflow.cpp started failing ...
Status: RESOLVED FIXED
Alias: None
Product: compiler-rt
Classification: Unclassified
Component: compiler-rt (show other bugs)
Version: unspecified
Hardware: PC Linux
: P normal
Assignee: Unassigned LLVM Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-11 18:20 PST by Nico Weber
Modified: 2016-03-14 12:34 PDT (History)
4 users (show)

See Also:
Fixed By Commit(s):


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2016-03-11 18:20:10 PST
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10500



Script:
--
D:/buildslave/clang-x64-ninja-win7/stage1/./bin/clang.exe  -fsanitize=float-cast-overflow D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp -o D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp _
env UBSAN_OPTIONS=print_summary=1:report_error_type=1  D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 0 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-0
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 1 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-1
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 2 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-2
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 3 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-3
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 4 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-4
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 5 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-5
D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 6 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-6
not  D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp 9 2>&1 | FileCheck D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp --check-prefix=CHECK-9
--
Exit Code: 1

Command Output (stdout):
--
Command 0: "D:/buildslave/clang-x64-ninja-win7/stage1/./bin/clang.exe" "-fsanitize=float-cast-overflow" "D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp" "-o" "D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp"
Command 0 Result: 0
Command 0 Output:
   Creating library D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.lib and object D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.exp



Command 0 Stderr:
D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:45:3: warning: expression result unused [-Wunused-value]

  (int)MaxFloatRepresentableAsInt; // ok

  ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:46:3: warning: expression result unused [-Wunused-value]

  (int)-MaxFloatRepresentableAsInt; // ok

  ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:49:3: warning: expression result unused [-Wunused-value]

  (int)MinFloatRepresentableAsInt; // ok

  ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:52:3: warning: expression result unused [-Wunused-value]

  (unsigned int)MaxFloatRepresentableAsUInt; // ok

  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 warnings generated.



Command 1: "D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp" "_"
Command 1 Result: 0
Command 1 Output:


Command 1 Stderr:


Command 2: "D:\buildslave\clang-x64-ninja-win7\stage1\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Float\Output\cast-overflow.cpp.tmp" "0"
Command 2 Result: 0
Command 2 Output:


Command 2 Stderr:


Command 3: "FileCheck" "D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp" "--check-prefix=CHECK-0"
Command 3 Result: 1
Command 3 Output:


Command 3 Stderr:
D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:89:14: error: expected string not found in input

 // CHECK-0: {{.*}}cast-overflow.cpp:[[@LINE+1]]:27: runtime error: value 2.14748{{.*}} is outside the range of representable values of type 'int'

             ^

<stdin>:1:1: note: scanning from here

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:90:27: runtime error: value 0 is outside the range of representable values of type 'int'

^

<stdin>:1:1: note: with expression "@LINE+1" equal to "90"

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:90:27: runtime error: value 0 is outside the range of representable values of type 'int'

^

<stdin>:1:85: note: possible intended match here

D:\buildslave\clang-x64-ninja-win7\llvm\projects\compiler-rt\test\ubsan\TestCases\Float\cast-overflow.cpp:90:27: runtime error: value 0 is outside the range of representable values of type 'int'

                                                                                    ^
Comment 1 Nico Weber 2016-03-11 18:21:50 PST
263111 kind of looks more likely, but they both don't look super likely :-/
Comment 2 Nico Weber 2016-03-11 19:21:06 PST
Actually, it looks like the test only used to fail in non-bootstrap builds, and now after my XFAIL change the bot with "unexpectedly passed in bootstrap"
Comment 3 Nico Weber 2016-03-11 19:36:35 PST
Actually, the first failing build is http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10486 which makes more sense (263080, 263081)
Comment 4 Nico Weber 2016-03-11 19:40:11 PST
Actually, it looks like the buildbot page doesn't list all revisions in that build. The previous build was at 263076, so 263077 263078 263079 might be it too.
Comment 5 Nico Weber 2016-03-11 19:42:30 PST
Pretty sure it's r263077.

-#if defined(__BIG_ENDIAN__)
+#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__

This is now true if neither is defined, which is the case when building with MSVC.
Comment 6 Nico Weber 2016-03-11 19:57:51 PST
Fixed in r263324.

Samsonov, please watch the tree a bit after landing changes.
Comment 7 Alexey Samsonov 2016-03-14 12:33:51 PDT
Nico, thank you for fixing this!

Sorry for not picking it up :(
I have received an email for http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10486, but my changes in the blame list seemed completely irrelevant (they actually were, as r263077 was not listed there).
Comment 8 Alexey Samsonov 2016-03-14 12:34:23 PDT
Nico, thank you for fixing this!

Sorry for not picking it up :(
I have received an email for http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10486, but my changes in the blame list seemed completely irrelevant (they actually were, as r263077 was not listed there).