LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 30261 - [Meta] 3.9.1 Merges and Bug Fixes
Summary: [Meta] 3.9.1 Merges and Bug Fixes
Status: NEW
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: 3.9
Hardware: PC All
: P normal
Assignee: Tom Stellard
URL:
Keywords:
Depends on: 30688 31320 29087 30296 30297 30298 30300 30301 30307 30352 30369 30393 30421 30463 30495 30555 30596 30599 30724 30725 30834 30839 30840 30850 30851 30852 30853 30855 30856 30864 30871 30872 30873 30874 30875 30876 30879 30881 30882 30883 30884 30969 30970 30971 30972 30979 31011 31023 31026 31035 31059 31072 31073 31083 31086 31087 31097 31102 31113 31120 31139 31140 31160 31174 31195 31204 31238 31272 31276
Blocks:
  Show dependency tree
 
Reported: 2016-09-02 14:26 PDT by Eric Fiselier
Modified: 2018-01-20 10:07 PST (History)
12 users (show)

See Also:
Fixed By Commit(s):


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Fiselier 2016-09-02 14:26:28 PDT
This patch is meant to track bug fixes and other patches that we want to merge into 3.9.1.
Comment 1 Eric Fiselier 2016-09-02 14:28:07 PDT
The following patch should be merged into 3.9.1

r279955 - Fix pair::operator=(TupleLike&&)

https://github.com/llvm-mirror/libcxx/commit/235d71f053d0a4160c67ec343712ae1223570c0d
Comment 2 Renato Golin 2016-09-02 19:31:24 PDT
This one too:

http://llvm.org/viewvc/llvm-project?view=revision&revision=279871
Comment 3 Renato Golin 2016-09-02 19:33:02 PDT
Tom, I'm assigning to you, as a stable release manager, for 3.9.1.
Comment 4 Eric Fiselier 2016-09-02 21:13:41 PDT
@Renato Are you aware this is currently binned under libc++?
Comment 5 Renato Golin 2016-09-03 05:59:01 PDT
No, why?
Comment 6 Eric Fiselier 2016-09-03 06:08:33 PDT
Sometimes libunwind stuff gets put here. Rebinning to new bugs to make this generic to LLVM.
Comment 7 Eric Fiselier 2016-09-05 19:38:23 PDT
r280190 should be applied as well.
Which fixes:
 - http://llvm.org/PR12298
 - http://llvm.org/PR29123
Comment 8 Simon Pilgrim 2016-09-14 16:12:39 PDT
"Don't reduce the width of vector mul if the target doesn't support SSE2."
https://llvm.org/bugs/show_bug.cgi?id=30298
https://reviews.llvm.org/D24288
https://reviews.llvm.org/rL280837
Comment 9 Dimitry Andric 2016-09-17 07:28:55 PDT
In FreeBSD's copy of 3.9 we have already applied the following post-3.9.0 patches.  These would all be nice to have in 3.9.1.

r280837 (bug 30298): Don't reduce the width of vector mul if the target doesn't support SSE2.

r280040 + r280041 (bug 19098): [PowerPC] Add support for -mlongcall

r280188 (bug 26856): [PowerPC] Don't spill the frame pointer twice

r280350 (bug 26761): Add ISD::EH_DWARF_CFA, simplify @llvm.eh.dwarf.cfa on Mips, fix on PowerPC

r280705 (bug 26519):  [PPC] Claim stack frame before storing into it, if no red zone is present

r281632 (bug 29140): Silence false positive diagnostics regarding passing an object of enumeration type to va_start().
Comment 10 Matthias Braun 2016-09-20 11:52:40 PDT
I'd like to nominate the fix for PR30199 (in r281957) to the 3.9.1 release.
Comment 11 Simon Pilgrim 2016-09-28 05:52:50 PDT
(In reply to comment #9)
> In FreeBSD's copy of 3.9 we have already applied the following post-3.9.0
> patches.  These would all be nice to have in 3.9.1.
> 
> r280837 (bug 30298): Don't reduce the width of vector mul if the target
> doesn't support SSE2.

Nadav has given his OK - shall I merge this into the 3.9 release branch?
Comment 12 Tom Stellard 2016-09-28 14:27:08 PDT
(In reply to comment #11)
> (In reply to comment #9)
> > In FreeBSD's copy of 3.9 we have already applied the following post-3.9.0
> > patches.  These would all be nice to have in 3.9.1.
> > 
> > r280837 (bug 30298): Don't reduce the width of vector mul if the target
> > doesn't support SSE2.
> 
> Nadav has given his OK - shall I merge this into the 3.9 release branch?

Yes, please merge it.
Comment 13 Simon Pilgrim 2016-10-03 05:44:59 PDT
I'd like to propose https://llvm.org/bugs/show_bug.cgi?id=30596 (https://reviews.llvm.org/D25039) for merging to 3.9.1:

[X86][AVX] Ensure broadcast loads respect dependencies. 

This was fixed at r283070:
http://llvm.org/viewvc/llvm-project?view=revision&revision=283070

With a preliminary test update at r282613:
http://llvm.org/viewvc/llvm-project?view=revision&revision=282613
Comment 14 Sylvestre Ledru 2016-11-01 15:03:27 PDT
I would like to nominate bug 30342. This is impacting rust, see https://github.com/rust-lang/rust/issues/36474
Comment 15 Dimitry Andric 2016-11-08 04:01:02 PST
Please merge http://llvm.org/viewvc/llvm-project?rev=286129&view=rev

Log:
[OPENMP] Fixed codegen for __real/__imag expressions in atomic constructs.
Comment 16 Gonzalo BG 2016-11-17 09:20:56 PST
This is a regression introduced in clang 3.9: 

https://llvm.org/bugs/show_bug.cgi?id=29087

which has a patch under review that, once accepted, should probably be part of some clang 3.9.x release:

https://reviews.llvm.org/D23765
Comment 17 Renato Golin 2016-11-18 04:51:56 PST
Hi Tom,

This is an important one to get into 3.9.1:

https://llvm.org/bugs/show_bug.cgi?id=31035

Or Clang up to 3.8 won't be able to compile compiler-rt 3.9.1 (as it can't compile 3.9.0 already). 

We'll get a commit to trunk as soon as possible, then I'll create a "merge bug" for the rev, but I'm assing that bug as a dep here to make sure we don't forget about it.

cheers,
--renato
Comment 18 Seo Sanghyeon 2016-11-22 04:50:26 PST
I would like to nominate bug 29163, which hurts Rust pretty badly: https://github.com/rust-lang/rust/issues/36023
Comment 19 Renato Golin 2016-11-22 05:50:00 PST
(In reply to comment #18)
> I would like to nominate bug 29163, which hurts Rust pretty badly:
> https://github.com/rust-lang/rust/issues/36023

Please, create a new bug called "Merge [commit] into 3.9.1" and make it a blocker to this one, depending on Bug #29163, and write on the body why is this important".

This short description with a link to the github issue is enough.

It seems we have documentation for most steps on our side, but this one above is not there. I'll add it.
Comment 20 Tom Stellard 2016-11-23 11:37:32 PST
(In reply to comment #13)
> I'd like to propose https://llvm.org/bugs/show_bug.cgi?id=30596
> (https://reviews.llvm.org/D25039) for merging to 3.9.1:
> 
> [X86][AVX] Ensure broadcast loads respect dependencies. 
> 
> This was fixed at r283070:
> http://llvm.org/viewvc/llvm-project?view=revision&revision=283070
> 
> With a preliminary test update at r282613:
> http://llvm.org/viewvc/llvm-project?view=revision&revision=282613

These have been merged.
Comment 21 Tom Stellard 2016-11-23 11:41:20 PST
(In reply to comment #14)
> I would like to nominate bug 30342. This is impacting rust, see
> https://github.com/rust-lang/rust/issues/36474

I've created a ticket to track this: https://llvm.org/bugs/show_bug.cgi?id=31139
Comment 22 Tom Stellard 2016-11-23 11:44:39 PST
(In reply to comment #15)
> Please merge http://llvm.org/viewvc/llvm-project?rev=286129&view=rev
> 
> Log:
> [OPENMP] Fixed codegen for __real/__imag expressions in atomic constructs.

I have opened https://llvm.org/bugs/show_bug.cgi?id=31140 to track this request.
Comment 23 Tom Stellard 2016-11-23 11:45:35 PST
(In reply to comment #17)
> Hi Tom,
> 
> This is an important one to get into 3.9.1:
> 
> https://llvm.org/bugs/show_bug.cgi?id=31035
> 
> Or Clang up to 3.8 won't be able to compile compiler-rt 3.9.1 (as it can't
> compile 3.9.0 already). 
> 
> We'll get a commit to trunk as soon as possible, then I'll create a "merge
> bug" for the rev, but I'm assing that bug as a dep here to make sure we
> don't forget about it.
> 
> cheers,
> --renato

This has been merged.
Comment 24 Tom Stellard 2016-11-23 11:48:18 PST
(In reply to comment #18)
> I would like to nominate bug 29163, which hurts Rust pretty badly:
> https://github.com/rust-lang/rust/issues/36023

This is request is being tracked by: https://llvm.org/bugs/show_bug.cgi?id=31113