LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 31204 - Merge r278268 into the 3.9 branch
Summary: Merge r278268 into the 3.9 branch
Status: RESOLVED WONTFIX
Alias: None
Product: libraries
Classification: Unclassified
Component: Register Allocator (show other bugs)
Version: 3.9
Hardware: PC Linux
: P normal
Assignee: Quentin Colombet
URL: https://reviews.llvm.org/rL278268
Keywords:
Depends on:
Blocks: 30261
  Show dependency tree
 
Reported: 2016-11-29 08:25 PST by Tom Stellard
Modified: 2016-12-06 14:16 PST (History)
3 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Stellard 2016-11-29 08:25:45 PST 
Hi Quentin,

Is this patch OK to merge to the 3.9 branch?
Comment 1 Quentin Colombet 2016-12-05 17:21:37 PST 
Adding Matthias who updated that part recently.
Comment 2 Matthias Braun 2016-12-05 18:10:39 PST 
Hmm that commit seems questionable in its current form (I never got around looking at it when it went in). I proposed an update in the original review (https://reviews.llvm.org/D23303).

It's likely that we just don't hit problems in repairIntervalsInRange() because it is used very rarely.
Comment 3 Matt Arsenault 2016-12-05 18:12:32 PST 
(In reply to comment #2)
> Hmm that commit seems questionable in its current form (I never got around
> looking at it when it went in). I proposed an update in the original review
> (https://reviews.llvm.org/D23303).
> 
> It's likely that we just don't hit problems in repairIntervalsInRange()
> because it is used very rarely.

The pass that hit this is now SSA and doesn't depend on LiveIntervals anymore, so it won't be able to hit this anymore
Comment 4 Tom Stellard 2016-12-06 14:16:40 PST 
Since we are already at -rc2, we'll skip merging this patch.  It seems too risky.