LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 31881 - Cherry pick r294088 to 4.0 branch (MachineCopyPropagation fix)
Summary: Cherry pick r294088 to 4.0 branch (MachineCopyPropagation fix)
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Common Code Generator Code (show other bugs)
Version: trunk
Hardware: PC All
: P normal
Assignee: Quentin Colombet
URL:
Keywords:
Depends on:
Blocks: 31622
  Show dependency tree
 
Reported: 2017-02-06 11:54 PST by Matthias Braun
Modified: 2017-02-08 10:43 PST (History)
2 users (show)

See Also:
Fixed By Commit(s):

Attachments
Patch adapted to 4.0 branch (4.67 KB, application/octet-stream)
2017-02-06 11:54 PST, Matthias Braun 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Braun 2017-02-06 11:54:21 PST 
Created attachment 17940 [details]
Patch adapted to 4.0 branch

r294088 addresses a miscompile in situations with non-coalesced COPY instructions in combination with deeper register hierarchies (ARMv7 neon in this case). The problem was found in swift code but the issue is general.

The patch needs to be slightly adapted for the 4.0 branch, I attached a patch.
Comment 1 Matthias Braun 2017-02-06 11:55:01 PST 
To code owner for 4.0 branch review.
Comment 2 Hans Wennborg 2017-02-06 16:30:20 PST 
(In reply to comment #1)
> To code owner for 4.0 branch review.

Did you mean to cc someone?
Comment 3 Matthias Braun 2017-02-06 20:02:59 PST 
(In reply to comment #2)
> (In reply to comment #1)
> > To code owner for 4.0 branch review.
> 
> Did you mean to cc someone?

I changed the "Assigned To:" field
Comment 4 Quentin Colombet 2017-02-07 15:31:31 PST 
SGTM.
Comment 5 Hans Wennborg 2017-02-08 10:43:08 PST 
r294473.