LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 32201 - Merge r294690 into the 4.0 branch
Summary: Merge r294690 into the 4.0 branch
Status: RESOLVED FIXED
Alias: None
Product: lld
Classification: Unclassified
Component: All Bugs (show other bugs)
Version: unspecified
Hardware: All All
: P enhancement
Assignee: Chandler Carruth
URL: https://reviews.llvm.org/rL294690
Keywords:
: 32224 (view as bug list)
Depends on:
Blocks: release-4.0.1
  Show dependency tree
 
Reported: 2017-03-09 13:17 PST by Tom Stellard
Modified: 2017-05-18 19:07 PDT (History)
2 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Stellard 2017-03-09 13:17:51 PST 
Is this patch OK to merge to the 4.0 branch?
Comment 1 Rui Ueyama 2017-03-09 14:07:20 PST 
Hans, what do you think?
Comment 2 Hans Wennborg 2017-03-10 08:41:28 PST 
I'm not a CMake expert, but it looks good as far as I can tell.

Watch out when merging, r294690 is touching both llvm and lld.
Comment 3 Tom Stellard 2017-04-21 06:21:56 PDT 
*** Bug 32224 has been marked as a duplicate of this bug. ***
Comment 4 Tom Stellard 2017-04-21 06:22:49 PDT 
Chandler, is this OK to merge?
Comment 5 Chandler Carruth 2017-05-16 11:27:01 PDT 
LGTM
Comment 6 Tom Stellard 2017-05-18 19:07:32 PDT 
Merged:
llvm: r303399
lld: r303400
clang-tools-extra: r303401