LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 32315 - merge r292034 to 4.0.1
Summary: merge r292034 to 4.0.1
Status: RESOLVED FIXED
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: trunk
Hardware: PC Linux
: P enhancement
Assignee: Hans Wennborg
URL: reviews.llvm.org/rL292034
Keywords:
Depends on: 32295
Blocks: release-4.0.1
  Show dependency tree
 
Reported: 2017-03-16 10:45 PDT by Hans Wennborg
Modified: 2017-04-26 14:48 PDT (History)
2 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2017-03-16 10:45:39 PDT 
merge r292034 to 4.0.1
Comment 1 Tom Stellard 2017-04-03 18:51:23 PDT 
This looks like it will break the ABI.  New 'const' versions of the functions need to be added instead of changing the existing functions (like what was done for the Iterator class).

Can you attach an updated patch?
Comment 2 Hans Wennborg 2017-04-26 14:48:43 PDT 
I tweaked it to not remove the old functions and merged in r301479.