LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 32794 - Merge r301328 into the 4.0 branch : [libclang] Check for a record declaration before a template specialization
Summary: Merge r301328 into the 4.0 branch : [libclang] Check for a record declaration...
Status: RESOLVED WONTFIX
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: 4.0
Hardware: All All
: P enhancement
Assignee: Richard Smith
URL: https://reviews.llvm.org/rL301328
Keywords:
Depends on:
Blocks: release-4.0.1
  Show dependency tree
 
Reported: 2017-04-25 11:48 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2017-05-23 10:31 PDT (History)
3 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2017-04-25 11:48:20 PDT 
Is this patch OK to merge to the 4.0 branch?
Comment 1 Tom Stellard 2017-04-25 16:40:41 PDT 
Hi Richard,

Is this OK to merge to the 4.0 branch?
Comment 2 Richard Smith 2017-04-26 14:35:10 PDT 
I've asked some questions on the review thread (https://reviews.llvm.org/D32348); this change alone seems to introduce inconsistency and potentially a regression compared to 4.0.
Comment 3 Tom Stellard 2017-05-19 11:27:51 PDT 
r301328 was reverted, so it won't be merged into 4.0.  However, since r301328 fixed a regression introduced by r287024, should we revert r287024 in the 4.0 branch?
Comment 4 Richard Smith 2017-05-19 11:57:31 PDT 
See https://reviews.llvm.org/D32566 for discussion. I think the conclusion there was to leave the existing 4.0 behavior alone, at least for 4.0.1.
Comment 5 Tom Stellard 2017-05-23 10:31:00 PDT 
OK, we won't merge this patch then.