LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 33217 - Merge r299634 into the 4.0 branch : [ARM] Remove a dead ADD during the creation of TBBs
Summary: Merge r299634 into the 4.0 branch : [ARM] Remove a dead ADD during the creati...
Status: RESOLVED WONTFIX
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: 4.0
Hardware: All All
: P enhancement
Assignee: Tim Northover
URL: https://reviews.llvm.org/rL299634
Keywords:
Depends on:
Blocks: release-4.0.1
  Show dependency tree
 
Reported: 2017-05-29 15:41 PDT by Ariel Ben-Yehuda
Modified: 2017-06-07 07:29 PDT (History)
3 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariel Ben-Yehuda 2017-05-29 15:41:06 PDT 
Is this patch OK to merge to the 4.0 branch?
Comment 1 Dave Green 2017-06-05 10:13:25 PDT 
Hello

I have no objections, although this was a minor optimisation, not a correctness fix. It doesn't come up very often (I believe you need a schedule to get it the instructions into the right order) and doesn't fix any bugs.

Probably best to just leave this one on trunk I'd say.
Dave
Comment 2 Tim Northover 2017-06-07 07:29:18 PDT 
Yeah, I'd skip this one I think.