LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 352 - include/{Support,Config} -> include/llvm/{Support,Config}
Summary: include/{Support,Config} -> include/llvm/{Support,Config}
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Support Libraries (show other bugs)
Version: 1.0
Hardware: All All
: P enhancement
Assignee: Reid Spencer
URL:
Keywords: code-cleanup
: 183 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-05-29 00:22 PDT by Reid Spencer
Modified: 2010-02-22 12:55 PST (History)
2 users (show)

See Also:
Fixed By Commit(s):


Attachments
Script to do the cvs repository modifications (1.64 KB, text/plain)
2004-09-01 01:49 PDT, Reid Spencer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Reid Spencer 2004-05-29 00:22:23 PDT
The include directory should contain exactly one directory: llvm.

All include/* directories need to be made into include/llvm/* directories.

The reason for this is so that llvm #includes (especally by users of LLVM)
cannot clash with any other software system. Right now we have header files in
include/Support and include/Config that could clash with header files from some
"Support" or "Config" application or module of an application.

After this change is made, including *any* LLVM header will have the form:

#include <llvm/MODULE/HEADER.h>
Comment 1 Reid Spencer 2004-05-29 00:49:45 PDT
*** Bug 183 has been marked as a duplicate of this bug. ***
Comment 2 Reid Spencer 2004-09-01 01:49:19 PDT
Created attachment 170 [details]
Script to do the cvs repository modifications

Review and run this script against the LLVM cvs repository in order to make
copies of ,v files for headers moved to new locations. This needs to be done
before I can commit the file modifications.
Comment 3 Reid Spencer 2004-09-01 01:50:30 PDT
The attachment needs to be run so I can commit changes.

Note that the resolution to this bug will also encapsulate the movement of
abstract data types from include/Support to include/llvm/ADT, as noted in bug 351. 


Comment 4 Reid Spencer 2004-09-01 01:55:19 PDT
One more thing to be done before resolving this:

Split the abstract data type implementations out of lib/Support and into
lib/ADT. This will also require a new library to be linked with in the various
tools.

Either that or rename libsupport.a libsupport+adt.a
Comment 5 Reid Spencer 2004-09-01 18:21:05 PDT
This change has been implemented. All public header files are now in
include/llvm. The change set is too big to list here but it begins with:

http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20040830/017770.html

and ends with:

http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20040830/017837.html

Yes, changes in 67 directories :)