LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 36320 - [Hexagon] crash: CANNOT select: t16: v32i1 = HexagonISD::QFALSE
Summary: [Hexagon] crash: CANNOT select: t16: v32i1 = HexagonISD::QFALSE
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Backend: Hexagon (show other bugs)
Version: trunk
Hardware: PC All
: P enhancement
Assignee: Unassigned LLVM Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-09 10:17 PST by Sanjay Patel
Modified: 2018-02-09 11:13 PST (History)
2 users (show)

See Also:
Fixed By Commit(s):


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sanjay Patel 2018-02-09 10:17:06 PST
The following is a slight modification of an existing Hexagon regression test at:
test/CodeGen/Hexagon/autohvx/isel-setcc-pair.ll

The only difference is that I have replaced an 'undef' operand of the vector 'and' instruction with a zero operand. 

As noted in bug 36305, our handling of undef operands in the DAG is wrong. In this particular case, I think the difference is caused because currently in the DAG for vectors we have:
and x, undef --> undef

But this is wrong. It should be:
and x, undef --> 0

-----------------------------------------------------------------------------

; RUN: llc -march=hexagon < %s | FileCheck %s
  
; Check that a setcc of a vector pair is handled (without crashing).
; CHECK: vcmp

target datalayout = "e-m:e-p:32:32:32-a:0-n16:32-i64:64:64-i32:32:32-i16:16:16-i1:8:8-f32:32:32-f64:64:64-v32:32:32-v64:64:64-v512:512:512-v1024:1024:1024-v2048:2048:2048"
target triple = "hexagon"

; Function Attrs: nounwind
define hidden fastcc void @fred(i32 %a0) #0 {
b1:
  %v2 = insertelement <32 x i32> undef, i32 %a0, i32 0
  %v3 = shufflevector <32 x i32> %v2, <32 x i32> undef, <32 x i32> zeroinitializer
  %v4 = icmp eq <32 x i32> %v3, undef
  %v5 = and <32 x i1> zeroinitializer, %v4
  br label %b6

b6:                                               ; preds = %b1
  %v7 = extractelement <32 x i1> %v5, i32 22
  br i1 %v7, label %b8, label %b9

b8:                                               ; preds = %b6
  unreachable

b9:                                               ; preds = %b6
  unreachable
}

attributes #0 = { nounwind "target-cpu"="hexagonv60" "target-features"="+hvx,+hvx-length64b" }
Comment 1 Sanjay Patel 2018-02-09 10:27:45 PST
Note: I have no idea if this is a legitimate test for Hexagon, but the crash is blocking a potential fix for bug 36305 that I was testing.
Comment 2 Krzysztof Parzyszek 2018-02-09 11:11:11 PST
Fixed in r324763.
Comment 3 Sanjay Patel 2018-02-09 11:13:02 PST
(In reply to Krzysztof Parzyszek from comment #2)
> Fixed in r324763.

Wow...thanks for the fast fix!