LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 36351 - Merge r324747 into the 6.0 branch : Reapply "AMDGPU: Add 32-bit constant address space"
Summary: Merge r324747 into the 6.0 branch : Reapply "AMDGPU: Add 32-bit constant addr...
Status: RESOLVED WONTFIX
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: 6.0
Hardware: All All
: P enhancement
Assignee: Unassigned LLVM Bugs
URL:
Keywords:
: 36352 (view as bug list)
Depends on:
Blocks: release-6.0
  Show dependency tree
 
Reported: 2018-02-12 07:25 PST by Marek Olšák
Modified: 2018-02-26 02:09 PST (History)
3 users (show)

See Also:
Fixed By Commit(s): r324747

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Olšák 2018-02-12 07:25:45 PST 
Is it OK to merge the following revision(s) to the 6.0 branch?
Comment 1 Marek Olšák 2018-02-12 07:25:51 PST 
https://reviews.llvm.org/rL324747
Comment 2 Marek Olšák 2018-02-12 07:30:07 PST 
Prerequisite:
https://bugs.llvm.org/show_bug.cgi?id=36350

Clang fix that should be applied at the same time:
https://bugs.llvm.org/show_bug.cgi?id=36352
Comment 3 Marek Olšák 2018-02-12 07:30:48 PST 
This is a feature for AMDGPU that we would like to have in LLVM 6.0.
Comment 4 Hans Wennborg 2018-02-13 06:43:51 PST 
+Matt to call it.

I'm not keen on adding new functionality this late in the release process.
Comment 5 Hans Wennborg 2018-02-19 07:46:49 PST 
Matt: ping?
Comment 6 Hans Wennborg 2018-02-19 07:48:04 PST 
*** Bug 36352 has been marked as a duplicate of this bug. ***
Comment 7 Hans Wennborg 2018-02-19 07:48:27 PST 
From 36352, also merge r324747 if we merge this.
Comment 8 Hans Wennborg 2018-02-21 05:13:28 PST 
Matt: ping?

Time for 6.0.0 is running out fast.
Comment 9 Matt Arsenault 2018-02-21 13:15:38 PST 
(In reply to Hans Wennborg from comment #8)
> Matt: ping?
> 
> Time for 6.0.0 is running out fast.

I think there should be a note about the support being experimental for addrspace 6, but I don’t think this should break anything else
Comment 10 Hans Wennborg 2018-02-22 03:19:15 PST 
(In reply to Matt Arsenault from comment #9)
> (In reply to Hans Wennborg from comment #8)
> > Matt: ping?
> > 
> > Time for 6.0.0 is running out fast.
> 
> I think there should be a note about the support being experimental for
> addrspace 6, but I don’t think this should break anything else

So you're saying we should merge this?

Can you please prepare patches that apply cleanly and pass tests on the branch?

I tried merging r324747+r324748 locally but get lots of clang test failures:

Failing Tests (18):
    Clang :: CodeGen/address-space.c
    Clang :: CodeGen/default-address-space.c
    Clang :: CodeGenCXX/amdgcn-automatic-variable.cpp
    Clang :: CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp
    Clang :: CodeGenCXX/vla.cpp
    Clang :: CodeGenOpenCL/addr-space-struct-arg.cl
    Clang :: CodeGenOpenCL/address-space-constant-initializers.cl
    Clang :: CodeGenOpenCL/address-spaces.cl
    Clang :: CodeGenOpenCL/amdgcn-automatic-variable.cl
    Clang :: CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
    Clang :: CodeGenOpenCL/amdgpu-env-amdgiz.cl
    Clang :: CodeGenOpenCL/amdgpu-sizeof-alignof.cl
    Clang :: CodeGenOpenCL/atomic-ops.cl
    Clang :: CodeGenOpenCL/byval.cl
    Clang :: CodeGenOpenCL/func-call-dbg-loc.cl
    Clang :: CodeGenOpenCL/lifetime.cl
    Clang :: CodeGenOpenCL/vla.cl
    Clang :: Index/pipe-size.cl
Comment 11 Marek Olšák 2018-02-23 08:37:40 PST 
Hans, I've changed my mind. Let's drop this and close/reject this request.