LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 36352 - Merge r324748 into the 6.0 branch : AMDGPU: Update for datalayout change
Summary: Merge r324748 into the 6.0 branch : AMDGPU: Update for datalayout change
Status: RESOLVED DUPLICATE of bug 36351
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: 6.0
Hardware: All All
: P enhancement
Assignee: Unassigned LLVM Bugs
URL:
Keywords:
Depends on:
Blocks: release-6.0
  Show dependency tree
 
Reported: 2018-02-12 07:26 PST by Marek Olšák
Modified: 2018-02-19 07:48 PST (History)
3 users (show)

See Also:
Fixed By Commit(s): r324748

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Olšák 2018-02-12 07:26:40 PST 
Is it OK to merge the following revision(s) to the 6.0 branch?
Comment 1 Marek Olšák 2018-02-12 07:26:45 PST 
https://reviews.llvm.org/rL324748
Comment 2 Hans Wennborg 2018-02-13 06:44:45 PST 
I don't have context. What datalayout change, and why does it need to be merged?

+Matt
Comment 3 Marek Olšák 2018-02-14 06:07:07 PST 
The commit should be applied together with:
[Bug 36351] Merge r324747 into the 6.0 branch : Reapply "AMDGPU: Add 32-bit constant address space"

That is, if one of them is merged, both of them should be merged. Otherwise, there will be lit tests failures.
Comment 4 Hans Wennborg 2018-02-19 07:48:04 PST 
Okay, let's just use one bug to track it.

*** This bug has been marked as a duplicate of bug 36351 ***