LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 38844 - __cpp_lib_make_unique not defined in <memory>
Summary: __cpp_lib_make_unique not defined in <memory>
Status: RESOLVED FIXED
Alias: None
Product: libc++
Classification: Unclassified
Component: All Bugs (show other bugs)
Version: 7.0
Hardware: PC Linux
: P enhancement
Assignee: Marshall Clow (home)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-05 08:10 PDT by Antony Polukhin
Modified: 2019-02-07 09:35 PST (History)
4 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antony Polukhin 2018-09-05 08:10:52 PDT 
Multiple projects suffer from that (see https://reviews.freebsd.org/rP460135 as an example).

Please add the following line

#define __cpp_lib_make_unique 201304

near make_unique definition.
Comment 1 Marshall Clow (home) 2018-09-05 09:57:02 PDT 
Currently, libc++ does not define any feature macros.

These were not required, but rather were advisory.
This will be changing for C++20 (see https://wg21.link/P0941)
Comment 2 Marshall Clow (home) 2018-09-05 10:01:44 PDT 
> Currently, libc++ does not define any feature macros.

Ok, I was wrong. We define a couple.
Someone must have snuck them in when I wasn't paying close enough attention.
Comment 3 Marshall Clow (home) 2019-02-07 09:35:35 PST 
This has been fixed.