LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 39330 - 7.0.1 backport: Assertion failed: (!m_first_die || m_first_die == m_die_array.front())…
Summary: 7.0.1 backport: Assertion failed: (!m_first_die || m_first_die == m_die_array...
Status: RESOLVED FIXED
Alias: None
Product: lldb
Classification: Unclassified
Component: All Bugs (show other bugs)
Version: 7.0
Hardware: PC Linux
: P normal
Assignee: David Bolvansky
URL:
Keywords:
Depends on:
Blocks: release-7.0.1
  Show dependency tree
 
Reported: 2018-10-16 11:59 PDT by Jan Kratochvil
Modified: 2018-11-15 22:04 PST (History)
3 users (show)

See Also:
Fixed By Commit(s): r344605 r347030

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kratochvil 2018-10-16 11:59:16 PDT 
Please backport:
  Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front())…
  https://reviews.llvm.org/rL344605
Comment 1 Tom Stellard 2018-10-19 14:13:13 PDT 
Hi Jason,

Is this OK to merge?
Comment 2 Jan Kratochvil 2018-11-01 13:02:49 PDT 
Hi Jason,
ping so that I am not accused of regressing even 7.0.1:
  [lldb-dev] LLVM 7.0.1-rc1 release on Thursday
  https://lists.llvm.org/pipermail/lldb-dev/2018-October/014326.html
Is this OK to merge? Thanks.
Comment 3 Jan Kratochvil 2018-11-04 07:07:29 PST 
Tom, if you are concerned about the trunk assertion adjustment couldn't me/you just remove the assertion?  I introduced the assertion recently in https://reviews.llvm.org/D46810 myself anyway.
Comment 4 Jan Kratochvil 2018-11-06 11:03:26 PST 
Hello David,
I need your review/approval for the 3-line backport mentioned above,
thanks. Do you find the change safe enough for the 7.0.1 branch?
Comment 5 David Bolvansky 2018-11-06 11:08:16 PST 
We backported this fix and all is OK.

I think you should merge it since the asserting code is too radical here.
Comment 6 David Bolvansky 2018-11-09 12:46:26 PST 
Added Pavel since he knows a bit about this issue (btw, pavel, is “depth” issue related to this fix or is it a second independent bug?)
Comment 7 Tom Stellard 2018-11-14 10:51:42 PST 
Merged: r346873
Comment 8 Tom Stellard 2018-11-15 22:04:36 PST 
Merged: r347030