LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 39584 - Merge r345353 into the 7.0 branch : Teach the DominatorTree fallback to recalculation when applying updates to speedup JT (PR37929)
Summary: Merge r345353 into the 7.0 branch : Teach the DominatorTree fallback to recal...
Status: RESOLVED FIXED
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: 7.0
Hardware: All All
: P enhancement
Assignee: Jakub Kuderski
URL:
Keywords:
Depends on:
Blocks: release-7.0.1
  Show dependency tree
 
Reported: 2018-11-07 23:01 PST by Chijun Sima
Modified: 2018-11-19 19:42 PST (History)
3 users (show)

See Also:
Fixed By Commit(s): r345353 r347285

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chijun Sima 2018-11-07 23:01:33 PST 
Is it OK to merge the following revision(s) to the 7.0 branch?
Comment 1 Chijun Sima 2018-11-07 23:01:41 PST 
https://reviews.llvm.org/rL345353
Comment 2 Chijun Sima 2018-11-07 23:15:53 PST 
r345353 fixes a regression in v7.0, which makes JumpThreading take an unacceptable amount of time on some inputs.

Relevant bug: https://bugs.llvm.org/show_bug.cgi?id=37929
Review link: https://reviews.llvm.org/D53245
Comment 3 Chijun Sima 2018-11-07 23:23:19 PST 
Rewording:

r345353 fixes a regression which makes JumpThreading take an unacceptable amount of time on some inputs in v7.0.
Comment 4 Tom Stellard 2018-11-15 20:12:13 PST 
Jakub,

You reviewed this patch, what do you think about merging this?
Comment 5 Jakub Kuderski 2018-11-16 14:36:29 PST 
This should be safe to merge, I don't know of any regression caused by the patch, while it solves some known (slowness) bugs.
Comment 6 Tom Stellard 2018-11-19 19:42:53 PST 
Merged: r347285