LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 42036 - RuntimeDyldMachOARM.h - comparison is always true due to limited range of data type
Summary: RuntimeDyldMachOARM.h - comparison is always true due to limited range of dat...
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Generic Execution Engine Support (show other bugs)
Version: trunk
Hardware: PC Windows NT
: P enhancement
Assignee: Unassigned LLVM Bugs
URL:
Keywords:
: 37195 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-05-27 10:38 PDT by Simon Pilgrim
Modified: 2019-09-06 10:26 PDT (History)
5 users (show)

See Also:
Fixed By Commit(s):

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pilgrim 2019-05-27 10:38:25 PDT 
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/7242/steps/build%20stage%201/logs/warnings%20%281%29

      uint16_t LowInsn = readBytesUnaligned(LocalAddress + 2, 2);
      assert((LowInsn & 0xf800) != 0xf8000 &&
             "Unrecognized thumb branch encoding (BR22 low bits)");

This warning suggests a typo in the assertion - should it be:

      assert((LowInsn & 0xf800) != 0xf800 &&
             "Unrecognized thumb branch encoding (BR22 low bits)");
Comment 1 Lang Hames 2019-05-27 14:35:09 PDT 
Thanks Simon -- nice catch!

Fixed in r361782.
Comment 2 Simon Pilgrim 2019-09-06 10:26:10 PDT 
*** Bug 37195 has been marked as a duplicate of this bug. ***