LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 44774 - basic_entry_values_x86_64 failing due to compiler changes
Summary: basic_entry_values_x86_64 failing due to compiler changes
Status: RESOLVED FIXED
Alias: None
Product: lldb
Classification: Unclassified
Component: All Bugs (show other bugs)
Version: unspecified
Hardware: PC All
: P normal
Assignee: labath
URL:
Keywords:
Depends on:
Blocks: 44116
  Show dependency tree
 
Reported: 2020-02-04 10:43 PST by Vedant Kumar
Modified: 2020-06-29 08:17 PDT (History)
7 users (show)

See Also:
Fixed By Commit(s): a5c23179826a6


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vedant Kumar 2020-02-04 10:43:26 PST
The basic_entry_values_x86_64 test has started failing today due to an argument being optimized out:

```
--- FileCheck trace (code=1) ---
/Users/vsk/src/builds/llvm-ub-hardening-RA/bin/FileCheck /Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp -check-prefix=FUNC1-DESC

FileCheck input:
      Address: a.out[0x0000000100000d68] (a.out.__TEXT.__text + 24)
      Summary: a.out`func1(int&, int) + 24 at main.cpp:52:1
       Module: file = "/Users/vsk/src/builds/llvm-ub-hardening-RA/lldb-test-build.noindex/functionalities/param_entry_vals/basic_entry_values_x86_64/lldbsuite.test.lldbtest.test_dsym/a.out", arch = "x86_64"
  CompileUnit: id = {0x00000000}, file = "/Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp", language = "c++11"
     Function: id = {0x7fffffff0000002e}, name = "func1(int&, int)", mangled = "_Z5func1Rii", range = [0x0000000103f25d50-0x0000000103f25d6f)
     FuncType: id = {0x7fffffff0000002e}, byte-size = 0, decl = main.cpp:35, compiler_type = "void (int &, int)"
       Blocks: id = {0x7fffffff0000002e}, range = [0x103f25d50-0x103f25d6f)
    LineEntry: [0x0000000103f25d68-0x0000000103f25d6f): /Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:52:1
       Symbol: id = {0x00000006}, range = [0x0000000103f25d50-0x0000000103f25d70), name="func1(int&, int)", mangled="_Z5func1Rii"



FileCheck output:

/Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:51:17: error: FUNC1-DESC: expected string not found in input
 // FUNC1-DESC: name = "sink", type = "int &", location = DW_OP_entry_value(DW_OP_reg5 RDI)
```

Perhaps the test needs to be re-written to check in a fixed assembly file, so that DW_OP_entry_value evaluation can be tested in a way that's not dependent on the compiler.
Comment 1 Djordje Todorovic 2020-02-04 23:29:17 PST
>Perhaps the test needs to be re-written to check in a fixed assembly file, so that DW_OP_entry_value evaluation can be tested in a way that's not dependent on the compiler.

It makes sense to me, since the entry values are "backup" locations depending on the code generated.
Comment 2 labath 2020-06-29 08:17:21 PDT
Fixed by a5c23179826a6.