This check has a lot of issue. It crashes with some macros - see here https://bugs.llvm.org/show_bug.cgi?id=47778 and a lot of fixes it suggests result in malformed code. I pushed a fix addressing the crashing as well as providing much more robust fixes(https://github.com/llvm/llvm-project/commit/a2e15fa532f36db7080347fbae31470c8ceaffc4). These fixes haven't had enough real world testing to justify backporting to the release, nor is the current release version really ready to stay in. I suggest patching out the check from the 12 branch in favour of introducing it in the 13 branch. Discussed with Aaron Ballman and he suggested this was probably a favourable approach.
FWIW, I think it's slightly preferred to back the check out of 12 instead of patching it at this late stage or leaving a known low-quality new check in the release.
Can you submit a patch to remove the check?
It may be a pain to submit a patch to remove it on the 13 branch, Is it easier to write a patch for the current 12 branch.
Created attachment 24561 [details] RemovePreferMemberInitializerCheck This should apply on the release/12.X branch cleanly and remove the check and all related docs and tests
Merged: a750a2329c433e598f7fc9655d625c5ebb6bc400