LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 5160 - ValueHandle is easy to confuse with active CallbackVHs
Summary: ValueHandle is easy to confuse with active CallbackVHs
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Core LLVM classes (show other bugs)
Version: trunk
Hardware: PC All
: P normal
Assignee: Jeffrey Yasskin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-09 20:29 PDT by Jeffrey Yasskin
Modified: 2009-10-12 12:46 PDT (History)
1 user (show)

See Also:
Fixed By Commit(s):

Attachments
Some tests for the brokenness (2.71 KB, patch)
2009-10-09 20:29 PDT, Jeffrey Yasskin 		Details
Proposed fix (8.05 KB, patch)
2009-10-11 00:46 PDT, Jeffrey Yasskin 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Yasskin 2009-10-09 20:29:13 PDT 
Created attachment 3634 [details]
Some tests for the brokenness

When CallbackVHs modify ValueHandles that refer to the same Value, this can crash the program or cause AssertingVHs to fail when they actually no longer refer to the Value. I'll be working on a fix.
Comment 1 Jeffrey Yasskin 2009-10-11 00:46:43 PDT 
Created attachment 3641 [details]
Proposed fix

This passes unittests and check-lit. Are there any other tests I should add?
Comment 2 Jeffrey Yasskin 2009-10-12 12:46:52 PDT 
Committed as r83861.