LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 876 - incorrect checking of the f2c / f95 library directory
Summary: incorrect checking of the f2c / f95 library directory
Status: RESOLVED FIXED
Alias: None
Product: Test Suite
Classification: Unclassified
Component: Programs Tests (show other bugs)
Version: 1.8
Hardware: All Linux
: P normal
Assignee: Reid Spencer
URL:
Keywords: build-problem
Depends on:
Blocks:
 
Reported: 2006-08-10 08:19 PDT by Kenneth Hoste
Modified: 2010-02-22 12:49 PST (History)
2 users (show)

See Also:
Fixed By Commit(s):


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Hoste 2006-08-10 08:19:33 PDT
In the configure file of llvm-test, libvar is used instead of libval, which
causes an incorrect error when specifying the F2C or F95 library directory using
--with-f2c-lib or --with-f95-lib. 
Solution:

replace

eval libvar=\$\{f95libdir\} 

with

eval libval=\$\{f95libdir\} 

Idem for f2c:

eval libvar=\$\{f2clibdir\} -> eval libval=\$\{f2clibdir\} 

Along with this, after checking if the specified directories are in fact
directories, the variable USE_F2C is set to 1, which is incorrect.

USE_F2C=1 should be replaced with USE_F2C="USE_F2C=1"

Same for USE_F95.
Comment 1 Chris Lattner 2006-08-14 16:42:17 PDT
Reid, any thoughts on this bug?
Comment 2 Reid Spencer 2006-08-14 17:38:17 PDT
Sounds straight forward enough. I have no way to test this, however.
I can make the changes if someone with f2c/f95 can do the testing.
Comment 3 Reid Spencer 2006-08-14 17:38:46 PDT
Mine
Comment 4 Reid Spencer 2006-08-14 18:24:49 PDT
Fixed.

Both problems are actually in LLVM, not llvm-test, so make sure to update the
llvm autoconf directory to get the new version of find_std_program.m4 and the
configure script. 

These are the patches: 

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036736.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036737.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036738.html

Thanks for pointing these out!

Reid.
Comment 5 Reid Spencer 2006-08-14 18:28:29 PDT
Kenneth,

One thing. Could you please obtain the changes I've committed and test them out?
I don't have f95/f2c here so I made the changes without testing them. They seem
pretty straight forward so I don't expect problems. However, it would be nice if
you could try it and then mark this bug "VERIFIED" if it works for you. If it
doesn't, please reopen it and indicate what went wrong.

Thanks for your help!

Reid.
Comment 6 Kenneth Hoste 2006-08-15 05:54:40 PDT
I can only test this at work, i.e. in one of the upcoming days... I'm not sure
how to obtain the changes you've comitted though, I'm fairly new to all this...
Comment 7 Reid Spencer 2006-08-15 11:43:00 PDT
Kenneth,

To test these changes you need to be working from the CVS version of LLVM. I
suggest you read the http://llvm.org/docs/GettingStarted.html document to learn
how to do that. If you're already working from CVS, the simply do:

cd /path/to/llvm/
cvs update
cd /path/to/llvm/projects/llvm-test
cvs update

If you can't use CVS for some reason, then you can review all the recent patches
I made in those directories and apply them yourself to your local copy. You can
find the patches here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/date.html

In addition to the ones I identified above, you also need these late breaking
patches:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036754.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036755.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036756.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036757.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060814/036758.html