Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Function::isExternal() -> isDeclaration() #1508

Closed
llvmbot opened this issue Jan 27, 2007 · 2 comments
Closed

Rename Function::isExternal() -> isDeclaration() #1508

llvmbot opened this issue Jan 27, 2007 · 2 comments
Labels
bugzilla Issues migrated from bugzilla code-cleanup llvm:core

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 27, 2007

Bugzilla Link 1136
Resolution FIXED
Resolved on Feb 22, 2010 12:48
Version trunk
OS All
Reporter LLVM Bugzilla Contributor

Extended Description

For people learning LLVM, the isExternal() method on Function can be confusing.
It gets confused with isExternalLinkage(). To make things more clear in the
code, I suggest we rename this to isDeclaration() or isPrototype(). This keeps
it clear from using the word External which can cause the confusion. There's no
functional change implied by this, just a name change.
@lattner
Copy link
Collaborator

lattner commented Jan 28, 2007

sounds like a good idea to me!

@llvmbot
Copy link
Collaborator Author

llvmbot commented Jan 30, 2007

Fixed.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla code-cleanup llvm:core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lattner @llvmbot