Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimplifyLibCalls should be merged into instcombine #12267

Closed
lattner opened this issue Jan 31, 2012 · 7 comments
Closed

SimplifyLibCalls should be merged into instcombine #12267

lattner opened this issue Jan 31, 2012 · 7 comments
Labels
bugzilla Issues migrated from bugzilla code-cleanup

Comments

@lattner
Copy link
Collaborator

lattner commented Jan 31, 2012

Bugzilla Link 11895
Resolution FIXED
Resolved on Jun 20, 2013 22:13
Version trunk
OS All
CC @nlewycky,@nunoplopes

Extended Description

Simplify libcalls was previously split out of instcombine so that it could be turned off with -fno-builtin. Now that we have TargetLibraryInfo around, we don't need to do this. Merging it into Instcombine's visitCall optimization logic would eliminate some phase ordering problems that it can have, and is a generally good cleanup anyway.
@llvmbot
Copy link
Member

llvmbot commented Feb 2, 2012

I would like to pick up this one if nobody is already working on it.

@lattner
Copy link
Collaborator Author

lattner commented Feb 2, 2012

Nice, please propose a plan on llvmdev, incremental is good :)

@llvmbot
Copy link
Member

llvmbot commented Feb 4, 2012

Cool. I am working on a proposal now.

@llvmbot
Copy link
Member

llvmbot commented Aug 2, 2012

Proposal here: http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-August/052283.html.

@llvmbot
Copy link
Member

llvmbot commented Aug 2, 2012

Assigning to myself to refine the proposal and implement it.

@llvmbot
Copy link
Member

llvmbot commented Oct 11, 2012

First patch series to implement this posted here: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20121008/152677.html.
After this initial patch gets reviewed, I can start doing the migration of the individual optimizations from SimplifyLibCalls to InstCombine fairly quickly.

@llvmbot
Copy link
Member

llvmbot commented Jun 21, 2013

This is resolved now. The simplify-libcalls pass has been fully migrated to the instcombine and function-attrs passes.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla code-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lattner @llvmbot