Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "implementation" keyword in AsmParser #1661

Closed
llvmbot opened this issue Mar 29, 2007 · 4 comments
Closed

Drop "implementation" keyword in AsmParser #1661

llvmbot opened this issue Mar 29, 2007 · 4 comments
Labels
bugzilla Issues migrated from bugzilla code-cleanup llvm:asmparser

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 29, 2007

Bugzilla Link 1289
Resolution FIXED
Resolved on Mar 06, 2010 14:00
Version trunk
OS All
Reporter LLVM Bugzilla Contributor

Extended Description

Before 2.0 ships, we need to drop support for parsing the implementation keyword
in AsmParser. The AsmWriter no longer generates it. It isn't needed. We also
don't want "checkpoint". Instead we do want the AsmParser to check for
incomplete types and values upon EOF. So, just move the checks done by
"implementation" into the code at the end of the parse. When this is done, the
test case:
test/Assembler/2003-12-30-TypeMapInvalidMemory.llx
will need to be updated to drop use of "implementation".
@llvmbot
Copy link
Collaborator Author

llvmbot commented Mar 30, 2007

Support for checking unresolved types and undefined values at the end of the
parse was added with this patch:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070326/046479.html

@llvmbot
Copy link
Collaborator Author

llvmbot commented Mar 30, 2007

All that remains to do is drop the implementation keyword. When do we do this?

@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 7, 2007

Can we drop this now? Its been over a week since we announced it going away.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 9, 2007

Its been ten days since we notified people that "implementation" was going away.
Now its gone:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070402/047046.html

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
kitano-metro pushed a commit to RIKEN-RCCS/llvm-project that referenced this issue Feb 14, 2023
llvm#1661 3053-regcのlit移行
5322bbe
troelsbjerre pushed a commit to troelsbjerre/llvm-project that referenced this issue Jan 10, 2024
@hyp
Merge pull request llvm#1661 from hyp/eng/hippoavx-bastille-in-minsk
6528fe1 
[darwin] Disable the -Wpsabi warning
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla code-cleanup llvm:asmparser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llvmbot